From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: ashleydlai@gmail.com, peterhuewe@gmx.de, tpmdd@selhorst.net,
jarkko.sakkinen@linux.intel.com, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, tpmdd-devel@lists.sourceforge.net
Subject: Re: [PATCH] tpm: vtpm: constify vio_device_id
Date: Thu, 17 Aug 2017 13:16:42 -0600 [thread overview]
Message-ID: <20170817191642.GF24735@obsidianresearch.com> (raw)
In-Reply-To: <a9ebcd668f5a7293c3805d0b6b21245f15c80212.1502989694.git.arvind.yadav.cs@gmail.com>
On Thu, Aug 17, 2017 at 11:04:21PM +0530, Arvind Yadav wrote:
> vio_device_id are not supposed to change at runtime. All functions
> working with vio_device_id provided by <asm/vio.h> work with
> const vio_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index f01d083..d2ce46b 100644
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -32,7 +32,7 @@
>
> static const char tpm_ibmvtpm_driver_name[] = "tpm_ibmvtpm";
>
> -static struct vio_device_id tpm_ibmvtpm_device_table[] = {
> +static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
> { "IBM,vtpm", "IBM,vtpm"},
> { "", "" }
> };
next prev parent reply other threads:[~2017-08-17 19:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 17:34 [PATCH] tpm: vtpm: constify vio_device_id Arvind Yadav
2017-08-17 19:16 ` Jason Gunthorpe [this message]
2017-08-18 11:32 ` Michael Ellerman
[not found] ` <87ziaxp0v5.fsf-W0DJWXSxmBNbyGPkN3NxC2scP1bn1w/D@public.gmane.org>
2017-08-18 20:31 ` Jason Gunthorpe
2017-08-19 17:21 ` Jarkko Sakkinen
[not found] ` <20170819172150.sta6erdmikpfkrgv-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-08-23 14:06 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817191642.GF24735@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=ashleydlai@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).