From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Alexander Steffen
<Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH RESEND 0/2] Avoid sending invalid data to the TPM
Date: Fri, 25 Aug 2017 19:44:16 +0300 [thread overview]
Message-ID: <20170825164416.svo7khm4zsmosxbx@linux.intel.com> (raw)
In-Reply-To: <20170824083545.13280-1-Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org>
On Thu, Aug 24, 2017 at 10:35:43AM +0200, Alexander Steffen wrote:
> When trying to send invalid commands (with mismatching commandSize values)
> to the TPM we discovered some cases in which data is sent to the TPM that
> should not be sent there. Similar problems were fixed years ago, but this
> one slipped through it seems.
>
> Alexander Steffen (2):
> tpm-dev-common: Reject too short writes
> tpm-interface: Fix checks of buffer size
>
> drivers/char/tpm/tpm-dev-common.c | 2 +-
> drivers/char/tpm/tpm-interface.c | 16 ++++++++--------
> drivers/char/tpm/tpm.h | 3 ++-
> 3 files changed, 11 insertions(+), 10 deletions(-)
>
> --
> 2.7.4
>
Have you checked that these do no break /dev/tpmrm0?
I have some cheap unit tests here to smoke it:
https://github.com/jsakkine-intel/tpm2-scripts
/Jarkko
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-08-25 16:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 8:35 [PATCH RESEND 0/2] Avoid sending invalid data to the TPM Alexander Steffen
[not found] ` <20170824083545.13280-1-Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org>
2017-08-24 8:35 ` [PATCH RESEND 1/2] tpm-dev-common: Reject too short writes Alexander Steffen
2017-08-25 16:54 ` Jarkko Sakkinen
[not found] ` <20170825165451.b7lv7t5w3nhbz7da-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-08-28 17:11 ` Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w
2017-08-30 10:40 ` Jarkko Sakkinen
2017-09-04 17:35 ` Alexander.Steffen
[not found] ` <dd865ba5751e4d568709e0aaf209633b-nFblLGNE8XKJSz+rYg/bSJowlv4uC7bZ@public.gmane.org>
2017-09-05 19:02 ` Jarkko Sakkinen
2017-08-24 8:35 ` [PATCH RESEND 2/2] tpm-interface: Fix checks of buffer size Alexander Steffen
2017-08-25 16:44 ` Jarkko Sakkinen [this message]
[not found] ` <20170825164416.svo7khm4zsmosxbx-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-01 12:08 ` [PATCH RESEND 0/2] Avoid sending invalid data to the TPM Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825164416.svo7khm4zsmosxbx@linux.intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).