Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>,
	linux-integrity@vger.kernel.org,
	David Howells <dhowells@redhat.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"open list:INTEGRITY MEASUREMENT ARCHITECTURE IMA"
	<linux-ima-user@lists.sourceforge.net>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	linux-security-module@vger.kernel.org,
	"moderated list:TPM DEVICE DRIVER"
	<tpmdd-devel@lists.sourceforge.net>,
	"open list:KEYS-TRUSTED" <keyrings@vger.kernel.org>,
	"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
	<linux-crypto@vger.kernel.org>,
	James Morris <james.l.morris@oracle.com>,
	Matt Mackall <mpm@selenic.com>open list:INTEGRITY MEASUREMENT
	ARCHITECTURE IMA
Subject: Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API
Date: Wed, 25 Oct 2017 21:11:23 +0200	[thread overview]
Message-ID: <20171025191123.4uqh6epwhak6hqp5@linux.intel.com> (raw)
In-Reply-To: <CANc+2y4BtQGqtC8RJL1Srrz_kWwhyveV3HBpfO1kikFj+0mHaA@mail.gmail.com>

On Wed, Oct 25, 2017 at 08:21:16PM +0530, PrasannaKumar Muralidharan wrote:
> >> > 2. Moving struct tpm_rng to the TPM client is architecturally
> >> >    uacceptable.
> >>
> >> As there was no response to the patch there is no way to know whether
> >> it is acceptable or not.
> >
> > I like the idea of removing the tpm rng driver as discussed in other
> > emails in this thread.
> 
> Thank you.

No, thank you.

I didn't first understand the big idea and only looked at the code
change per se. I apologize for that.

The problem that you went to solve was real and it led to a properly
implemented solution. You were not late from the party. Jason's code
change is derivative work of your code change. That's why his code
change has also your signed-off-by.

Thanks for doing awesome work :-)

/Jarkko