From: Nick Desaulniers <nick.desaulniers@gmail.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Ruben Roy <rubenroy2005@gmail.com>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
trivial@kernel.org
Subject: Re: [PATCH] tpm: fix duplicate inline declaration specifier
Date: Fri, 29 Sep 2017 17:46:41 -0700 [thread overview]
Message-ID: <CAH7mPvhP7i=6AThzfzP1W4wXuywcjj+bn8Pu0kaBAVg7rx0fZw@mail.gmail.com> (raw)
In-Reply-To: <20170929171704.azziyvlikbv5qnbd@linux.intel.com>
Thanks! This fixes a warning I was seeing with Clang:
drivers/char/tpm/tpm.h:560:15: warning: duplicate 'inline' declaration
specifier [-Wduplicate-decl-specifier]
On Fri, Sep 29, 2017 at 10:17 AM, Jarkko Sakkinen
<jarkko.sakkinen@linux.intel.com> wrote:
> On Tue, Sep 26, 2017 at 01:58:57PM +0000, Ruben Roy wrote:
>> This commit fixes the duplicate inline declaration specifier in
>> tpm2_rc_value which caused a warning
>>
>> Signed-off-by: Ruben Roy <rubenroy2005@gmail.com>
>> ---
>> drivers/char/tpm/tpm.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
>> index 04fbff2..f4d0272 100644
>> --- a/drivers/char/tpm/tpm.h
>> +++ b/drivers/char/tpm/tpm.h
>> @@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
>> }
>> #endif
>>
>> -static inline inline u32 tpm2_rc_value(u32 rc)
>> +static inline u32 tpm2_rc_value(u32 rc)
>> {
>> return (rc & BIT(7)) ? rc & 0xff : rc;
>> }
>> --
>> 1.8.3.1
>>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> /Jarkko
next prev parent reply other threads:[~2017-09-30 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 13:58 [PATCH] tpm: fix duplicate inline declaration specifier Ruben Roy
2017-09-29 17:17 ` Jarkko Sakkinen
2017-09-30 0:46 ` Nick Desaulniers [this message]
2017-10-04 11:31 ` Jarkko Sakkinen
[not found] ` <20171004113112.u5jnf3ims7vcxo7b-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-04 11:34 ` Ruben Roy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH7mPvhP7i=6AThzfzP1W4wXuywcjj+bn8Pu0kaBAVg7rx0fZw@mail.gmail.com' \
--to=nick.desaulniers@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=rubenroy2005@gmail.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).