u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: mchitale@ventanamicro.com
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Rick Chen <rick@andestech.com>,  Leo <ycliang@andestech.com>,
	Bin Meng <bmeng.cn@gmail.com>, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v4 0/4] SPL NVMe support
Date: Wed, 12 Jul 2023 18:36:27 +0530	[thread overview]
Message-ID: <042cf19a45191fb36e5fc00662273d84fc60c217.camel@ventanamicro.com> (raw)
In-Reply-To: <168726816209.294140.1474019151902272300.b4-ty@konsulko.com>

Hi Tom,

On Tue, 2023-06-20 at 09:37 -0400, Tom Rini wrote:
> On Sat, 03 Jun 2023 19:32:52 +0530, Mayuresh Chitale wrote:
> 
> > This patchset adds support to load images of the SPL's next booting
> > stage from a NVMe device.
> > 
> > Changes in v4:
> > - Drop patch 4
> > - Modify patch 2 to use generic fs.h APIs
> > 
> > [...]
> 
> With one change, which is that the "disk/part.c" in 4/4 were not
> required for
> any platform in tree and also broke testcases, and so was dropped,
> this has now
> been applied to u-boot/next. If you can explain a bit more what the
> problem you
> had was, we can look in to it. I suspect you need to test for not
> SPL_ENV_SUPPORT  but ENV_SUPPORT itself.
> 
Thanks. 
When SPL_NVME is enabled the build breaks with the following error:
riscv64-unknown-linux-gnu-ld.bfd: disk/part.o: in function
`blk_get_device_part_str':
u-boot/disk/part.c:473: undefined reference to `env_get'
make[2]: *** [u-boot/scripts/Makefile.spl:527: spl/u-boot-spl] Error 1
make[1]: *** [/u-boot/Makefile:2053: spl/u-boot-spl] Error 2

One possible fix is:

if ((!IS_ENABLED(CONFIG_SPL) && IS_ENABLED(CONFIG_ENV_SUPPORT)) ||    
       (IS_ENABLED(CONFIG_SPL) && IS_ENABLED(CONFIG_SPL_ENV_SUPPORT)))
	if (!dev_part_str || !strlen(dev_part_str)
|| !strcmp(dev_part_str, "-"))
	dev_part_str = env_get("bootdevice");



  reply	other threads:[~2023-07-12 13:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-03 14:02 [PATCH v4 0/4] SPL NVMe support Mayuresh Chitale
2023-06-03 14:02 ` [PATCH v4 1/4] spl: Add Kconfig options for NVME Mayuresh Chitale
2023-06-03 14:02 ` [PATCH v4 2/4] spl: blk: Support loading images from fs Mayuresh Chitale
2023-06-03 14:02 ` [PATCH v4 3/4] nvme: pci: Enable for SPL Mayuresh Chitale
2023-06-03 14:02 ` [PATCH v4 4/4] common: spl: Add spl NVMe boot support Mayuresh Chitale
2023-06-20 13:37 ` [PATCH v4 0/4] SPL NVMe support Tom Rini
2023-07-12 13:06   ` mchitale [this message]
2023-07-12 13:27     ` Heinrich Schuchardt
2023-07-12 17:12       ` Tom Rini
2023-07-17  8:09         ` mchitale
2023-07-17 15:12           ` Tom Rini
2023-07-20  6:17             ` mchitale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=042cf19a45191fb36e5fc00662273d84fc60c217.camel@ventanamicro.com \
    --to=mchitale@ventanamicro.com \
    --cc=bmeng.cn@gmail.com \
    --cc=rick@andestech.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).