u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: Pull request: u-boot-spi/master
Date: Tue, 21 Apr 2020 15:19:20 -0400	[thread overview]
Message-ID: <20200421191920.GO4555@bill-the-cat> (raw)
In-Reply-To: <20200421082404.10824-1-jagan@amarulasolutions.com>

On Tue, Apr 21, 2020 at 01:54:04PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 8d5d3bcf3c53d798bd7f3fe7092e994593bcc41c:
> 
>   Merge branch '2020-04-16-master-imports' (2020-04-17 11:17:29 -0400)
> 
> are available in the Git repository at:
> 
>   https://gitlab.denx.de/u-boot/custodians/u-boot-spi master
> 
> for you to fetch changes up to 48465bbc84d2f3824641b7627f417e36f515c896:
> 
>   mtd: spi-nor-ids: Add Spansion s25fs512s flash entry (2020-04-20 23:55:06 +0530)
> 

NAK, a handful of boards fail like this:
+(firefly-px30) In file included from include/configs/px30_common.h:52,
+(firefly-px30)                  from include/configs/evb_px30.h:9,
+(firefly-px30)                  from include/config.h:5,
+(firefly-px30)                  from include/common.h:16,
+(firefly-px30)                  from env/common.c:10:
+(firefly-px30) include/config_distro_bootcmd.h:402:2: error: expected '}' before 'BOOTENV_DEV_NAME_SF'
+(firefly-px30)   402 |  BOOTENV_DEV_NAME_##devtypeu(devtypeu, devtypel, instance)
+(firefly-px30)       |  ^~~~~~~~~~~~~~~~~
+(firefly-px30) include/configs/rockchip-common.h:45:31: note: in expansion of macro 'BOOTENV_DEV_NAME'
+(firefly-px30)    45 |  #define BOOT_TARGET_SF(func) func(SF, sf, 0)
+(firefly-px30)       |                               ^~~~
+(firefly-px30) include/configs/rockchip-common.h:55:2: note: in expansion of macro 'BOOT_TARGET_SF'
+(firefly-px30)    55 |  BOOT_TARGET_SF(func)
+(firefly-px30)       |  ^~~~~~~~~~~~~~
+(firefly-px30) include/config_distro_bootcmd.h:404:18: note: in expansion of macro 'BOOT_TARGET_DEVICES'
+(firefly-px30)   404 |  "boot_targets=" BOOT_TARGET_DEVICES(BOOTENV_DEV_NAME) "\0"
+(firefly-px30)       |                  ^~~~~~~~~~~~~~~~~~~
+(firefly-px30) include/config_distro_bootcmd.h:423:2: note: in expansion of macro 'BOOTENV_BOOT_TARGETS'
+(firefly-px30)   423 |  BOOTENV_BOOT_TARGETS \
+(firefly-px30)       |  ^~~~~~~~~~~~~~~~~~~~
+(firefly-px30) include/configs/px30_common.h:58:2: note: in expansion of macro 'BOOTENV'
+(firefly-px30)    58 |  BOOTENV
+(firefly-px30)       |  ^~~~~~~
+(firefly-px30) include/env_default.h:111:2: note: in expansion of macro 'CONFIG_EXTRA_ENV_SETTINGS'
+(firefly-px30)   111 |  CONFIG_EXTRA_ENV_SETTINGS
+(firefly-px30)       |  ^~~~~~~~~~~~~~~~~~~~~~~~~
+(firefly-px30) In file included from env/common.c:26:
+(firefly-px30) include/env_default.h:22:37: note: to match this '{'
+(firefly-px30)    22 | const uchar default_environment[] = {
+(firefly-px30)       |                                     ^
+(firefly-px30) make[2]: *** [env/common.o] Error 1
+(firefly-px30) make[1]: *** [env] Error 2
+(firefly-px30) make: *** [sub-make] Error 2

See https://gitlab.denx.de/u-boot/u-boot/-/jobs/80958 and
https://gitlab.denx.de/u-boot/u-boot/-/jobs/80910

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200421/f4480287/attachment.sig>

  reply	other threads:[~2020-04-21 19:19 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21  8:24 Pull request: u-boot-spi/master Jagan Teki
2020-04-21 19:19 ` Tom Rini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-01-29 17:53 Jagan Teki
2024-01-29 18:50 ` Tom Rini
2023-07-13 16:36 Jagan Teki
2023-07-14 16:05 ` Tom Rini
2023-05-01 17:12 Jagan Teki
2023-05-01 22:46 ` Tom Rini
2023-01-26 17:52 Jagan Teki
2023-01-26 20:09 ` Tom Rini
2022-11-02  6:08 Jagan Teki
2022-11-02 15:34 ` Tom Rini
2022-10-25 12:26 Jagan Teki
2022-10-25 16:27 ` Tom Rini
2022-07-18 19:35 Jagan Teki
2022-07-19 14:51 ` Tom Rini
2022-05-04  6:11 Jagan Teki
2022-05-04 15:41 ` Tom Rini
2022-03-12  8:44 Jagan Teki
2022-03-13 12:17 ` Tom Rini
2021-12-26 18:57 Jagan Teki
2021-12-27 13:25 ` Tom Rini
2021-10-23 13:35 Jagan Teki
2021-10-23 20:10 ` Tom Rini
2021-08-03 16:24 Jagan Teki
2021-08-04  1:14 ` Tom Rini
2021-02-26 17:22 Jagan Teki
2021-02-26 20:10 ` Tom Rini
2020-12-18 17:54 Jagan Teki
2020-12-20 23:06 ` Tom Rini
2020-07-20 17:14 Jagan Teki
2020-07-22  3:04 ` Tom Rini
2020-07-11 17:02 Jagan Teki
2020-07-13 15:28 ` Tom Rini
2020-06-11 17:53 Jagan Teki
2020-06-14 16:00 ` Tom Rini
2020-06-02 18:54 Jagan Teki
2020-06-03 18:09 ` Tom Rini
2020-05-09 16:26 Jagan Teki
2020-05-09 20:58 ` Tom Rini
2020-05-10 14:19   ` Jagan Teki
2020-05-10 19:36     ` Tom Rini
2020-04-03 14:30 Jagan Teki
2020-04-05 23:04 ` Tom Rini
2020-01-27 17:48 Jagan Teki
2020-01-28 16:04 ` Tom Rini
2019-12-27 12:20 Jagan Teki
2019-12-28  4:30 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421191920.GO4555@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).