From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93892C433EF for ; Mon, 27 Sep 2021 11:25:28 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0203C60EFD for ; Mon, 27 Sep 2021 11:25:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0203C60EFD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA53A8364F; Mon, 27 Sep 2021 13:24:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="G2cNNKyn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 389A48361B; Mon, 27 Sep 2021 13:23:07 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on061e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::61e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 77B0983622 for ; Mon, 27 Sep 2021 13:22:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YZP3r9HHHxm/aK+Lew5PdX77WsS3EE9OWNZtBg2LH+e//L3B/K5QmzgieXGkoTa6Rap/7y5qADj01kwb+dq/g3eLHUHlMuGJ2fZ+WOnrI4eT+nT1iaFyNvoZGUj/ZniRlfaiU0K7z3KmK9gpdsMHOIVpIvPOWK7hGOJbLoiyLwr9xo4vlf22e8PKwEjwEG7nsmtHbNwqD/UHpEUng5I0QZGaoshoIR6arzTorJEWqb5QjUodJatuIu1bKDM/lQEUyNchfUM4FqjA3RccTkqyEl2HWL90a34mfXt/am0sziEM1Ieb/lIxLeQDgkZRPOTBoaJp+uHn7TBCqJWcz53x/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=geISJdTja18WX/ygNbrWFiPLN5N+oN98VvQSF+fBX7g=; b=JzCybVqWHvmDCVWIIOhhdpVxFWNyCES6R/vPx328HBsQ9Nd2Wv36Ib0wMWnMIyj0689k483l8owRwvtsn3N6rHN2CdUgAy4qPH/DSQtfqZetz2pPJkYSY+v6ktFCBhDIkuP6qClImVGQXANNOCX+rYvpdgxW1s4btWCEYLcSBmryenSrx/SknEBxjNJd2NKJ8haZH2D0HA6fZUCIC9O+tyWF2u7wfMPgFgeTbt2GiAZ+NMEG6HqcjqXHrPUiqlwXH9i48OtBurKpGaZQ31TLaRMJdWqe20uvQBcZWXDlSw1RoCe54lpwVpAnXxnkWudSGjoH3fxiseKyPgBSRaIhlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=geISJdTja18WX/ygNbrWFiPLN5N+oN98VvQSF+fBX7g=; b=G2cNNKyn2VgwGMCPcBEQjOShjNU432smdl1KI/kWKIZNhIovYJDz/FELaEs/UZdX69So3ml4V7ONE5RM2dQqFYVJYZLRXz3KcK3p8cBkKi2E3yCJNqjYpSO6BOOdNqyhKiCvPDG5Xc3tstvqcRrGQzhjEec/lQdXR6jLws4ylLU= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0402MB3839.eurprd04.prod.outlook.com (2603:10a6:803:21::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.20; Mon, 27 Sep 2021 11:22:29 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:29 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 17/25] net: smc911x: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation Date: Mon, 27 Sep 2021 14:21:57 +0300 Message-Id: <20210927112205.301876-18-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69dc3266-8bd2-4c24-604f-08d981a9177c X-MS-TrafficTypeDiagnostic: VI1PR0402MB3839: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Ul+n6jBEuxLay+P7IwJamYeIFTcE2tcqGkyJtqFNKW4kqARRgNA9OMs6/5yJU/BLDOY9iCrzsJSuYXZuogAdWJcI3J2gHdK8CMoE90kAP41sB7OoMdHLQ3hhtBUknzNyenhuHuAOwo3xrRFQYqCrHm2Lj2GwcCS/hznm83fsqHdsaJGMY9QvLu/Lnz0dwMgpUY31lty7l9R1a3MqeEV4tcKMzb0uPrFgbx/IxbuSbh2OrYDcIxAgX+OEo73tQcS8EluZO2CZ3KX07bzRYIMDO9a7OA/MvWDiNVUwsSzUx6QnTG5fL1t5/5mxBg18iOhKuCSzD9Rn2G9EtZd4fmTiaPFMvtxP2ITDRNIsRO/vWi/C5UfVBGz9FeKWAugw7jotura76VCuKRXSzX1WKVFyIrj7fZTkkZfoPQjjAqqOuiPcEh5RppV9Vp6pT/OShfuHk3e8Hh6Ucm5P6QCUUpj11eDl1fGe4ksVaS8amzWSKzz3OhJOipzzeFNtReVXEvHFMk21Kow/H7EgKTrsCH2yJeSVc5LUDKGWsIY5GGNAcdMNWDiu8yL6yQTxIsgNTPctoLSUQfBf1x2pUX/on5DUXzP1Yy3KnujhZZ1sxktoMvxk19rMr0Z72Nl/sE04gWdc9XI5H/qay1qYDvkr/rZ5rjz54AK0nHj+UQiypFYpbJ3wF/e/f12kNnhyKpjXdEAj207q0ybCRBqdmryHU5sHA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6512007)(6916009)(956004)(6506007)(8676002)(38350700002)(86362001)(1076003)(38100700002)(508600001)(2906002)(54906003)(66476007)(6486002)(52116002)(36756003)(186003)(66556008)(66946007)(2616005)(5660300002)(83380400001)(26005)(6666004)(8936002)(44832011)(316002)(4326008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hoeGLSsTLtx+W6W6XGz7u/ylNSlsyXbp8+HOsmX8oC836boUsTun0H5JC2LM?= =?us-ascii?Q?VQ6zk8RQTAdBiM3BpvMt+Dyn3O3Q98erG8toTf2llSYZswOEyzEdDUzu1wR0?= =?us-ascii?Q?1L3YWWTMlvRDMcqUYrTpdLuiJJn1XvXg373Lj/8jttBjSeB5b94BtOTPfvXW?= =?us-ascii?Q?NONMcBcGQwdhGB95fk3q/yc0B9CGQ7gEKNtzmO+eUn4Ewgj9xVJ8J4b1ElzF?= =?us-ascii?Q?W4nkMDjNZZxIIm/unIKLNTDv1CjGsVZ4Lw+/PF/WA8Va21GqjPai2GOa6kKq?= =?us-ascii?Q?lgS1eRWCLPDGXXLblDER6Idy7i08PgCR3uLrpVlpt6yM1aVW05cBd9YZVrWT?= =?us-ascii?Q?xO3UpAFveucYE5Q25pFxLLgfmSpP95v5pGfPjf7/jTpNep4Rn82ZLVsLtUmI?= =?us-ascii?Q?g+6E8rU7ngT/NdS0689SICoQE7O3cWNqJQMLjXYiXBjCTLPPy08+KUvAAQQq?= =?us-ascii?Q?YZWmHO47Fqgjqyb6YTpRhLU22mJWhQuGnWeB8FtkGLCREPtB95nuDRuWR5g7?= =?us-ascii?Q?dmkwc61m6EnK5ewunlLams5PcucAIMVlUiG6Srxm94skiUeNOo1UBQklhdtk?= =?us-ascii?Q?TtgRDqD3JAFgc6WSr1c6rldrUs9/xEGbZJZHbemdX7Rt5LhUSd+LhnR1pg45?= =?us-ascii?Q?+suMxmde7gx7wDdi6yRtfBTohh6Z5uBWbcRVp7jxSgRFV8vHPhIh8ZHpz+ba?= =?us-ascii?Q?isXMQ8j6sT6r0EuGbiFgmIUSay7wgDzodMZi2fJO/XEsYaLSdlHkxkM69P64?= =?us-ascii?Q?GlJeEGfjti5KEyomRDvssP4zZhRvf4ETq1jf4oocUGMV1DY+DbcRA1O6G+vN?= =?us-ascii?Q?XhWGJ+/uV/va1jOJ7vhPaG5Pfix3uKj0/ukuualZw1iX/UFpRp0g9NSm2iyn?= =?us-ascii?Q?Js6Veb5gpvYUaYw1hqAB1xzWao3DnbzOy+TXRIH9Zak4K1wRloCldIxiWerl?= =?us-ascii?Q?7Y9J4LTSrXxNg/VtpZuXXt4dIAFhB5mpU8pg3YyyRN3BHUhQ59ZZcT3zZJY8?= =?us-ascii?Q?InHopPPn1suIIp7aqG10btgWJRZXVZHngeRaKYY3aNdSg5qi+/90BxOFfDyp?= =?us-ascii?Q?FxvaC/mGE2fPXl4GRvN1haHtXoetnWMC28j00jMb4RlS6AMGlxqLqFMXTYFP?= =?us-ascii?Q?dcatcwh7xkJhO4SUdJhYvd1YHImOn7Utaul2nYZ//x/m2fsQlO6YuaZreIZ1?= =?us-ascii?Q?Zp8+/z6f7Q3CHH6KV5PqvoVEQ83ssC94Gw5wXLzMHiKcOQtJRvVF8A0p8A05?= =?us-ascii?Q?ZepXyRDhI2peo3DYo4mlq086Uuf0FXg8KdRhiN9sZzZJMJTfh6yTbri0lF8P?= =?us-ascii?Q?XM5tR0b760VeigehS5Cb/M21?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69dc3266-8bd2-4c24-604f-08d981a9177c X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:29.5347 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ABFlPEcyC4DeLu6DQK8JpXOWDpBjx8UPBfijMwQKJawrMN9lA/9WMQlxWLwqvrw86wNOVO9TtCz+BXqtUuigxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3839 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more difficult to maintain. The chosen alternative is to use strlcpy(), which properly limits the copy len in the (srclen >= size) case to "size - 1", and which is also more efficient than the strncpy() byte-by-byte implementation by using memcpy. The destination string returned by strlcpy() is always NULL terminated. Signed-off-by: Vladimir Oltean --- drivers/net/smc911x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index 8f420261fa8d..5d9a73f23d75 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -425,7 +425,7 @@ static int smc911x_initialize_mii(struct smc911x_priv *priv) if (!mdiodev) return -ENOMEM; - strncpy(mdiodev->name, priv->dev.name, MDIO_NAME_LEN); + strlcpy(mdiodev->name, priv->dev.name, MDIO_NAME_LEN); mdiodev->read = smc911x_miiphy_read; mdiodev->write = smc911x_miiphy_write; -- 2.25.1