From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A9BC433EF for ; Mon, 27 Sep 2021 11:27:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B605960F4B for ; Mon, 27 Sep 2021 11:27:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B605960F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 650DF83659; Mon, 27 Sep 2021 13:27:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="XlbQgK58"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4F77C8348D; Mon, 27 Sep 2021 13:23:16 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0622.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::622]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8BBDD83634 for ; Mon, 27 Sep 2021 13:22:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YOK8a5b0zD2Qg2i6t29X02TAk4QSiIqRzLacgQhriscfPWM4eVMUyHajxWsQoLMc3WM5TtTMUCor6cqAkGSbpCbfcLOAb6GTxst/7655wGoAeohjnfrpieoiBcdAjmgTxZPKHt+0x5i1rIu/qBynGj+cFReH+S+43ygJCBPBr+PlRzsgSISDo//R6AOKPOwEWUJMjjHixjLRSIVAvJwDoxx6Nwgy4is51mEkH7Bev4Zh+6VCaskUDGEowaK4VKMtK8mKFDQBMawQqy7I0jWyst+0zRM1f7gPrZSVa9kDtWilKKMiHqVsF28k07FjWplEffuBomYnVEfrmRwijo/QIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8o1SyUNSWyI5ohL8mmmX8/OrvyGicN4aCUP8D5eCik0=; b=BS2DxQVGBfdxYxlghufP9Vg1BhUuOe6+RFxfl0JgtS6zHELdmsE7DjXBbAu2crxdzJM9lg2vbPgTCIr89YV1/c1lK8rRG56tdrU243zEETQSsKDFm1IFA5o+Re1Q5zshK2Tq4PLuPDBLdMzRqsEQaSHaGr8ZpAF2z02sSdQoxcXNvXPB9gx8/mxT4CNnx72psov33sU03jv8PKefP00uQ0EMcoMoZZKh8J7WelRcgDB9xoTjJnqL5gNbmRis4gkpI35+TN/7bSjGUUfKcXGboUXWKGjsfyN8Ti8x1v8oKRm67P+AEtrkjGJwR396x61fWmK6CGqjCJPLBUZgTQTt5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8o1SyUNSWyI5ohL8mmmX8/OrvyGicN4aCUP8D5eCik0=; b=XlbQgK58rv7MkGa97D0t9MPLdBt8vfwakPLUnKrOq9Ef3Q1Dcn/y91ZI3pPcfWEsixnOv6H1HeHtGRrsKqgMNrOqQKezD9TkYJqt5SsohLPL8c3TLuJFoWhd8VH4K2DNbSmx6FefKYJHI669BxAiqz2kSVPMtjt/FUDaySg0Ta8= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0402MB3839.eurprd04.prod.outlook.com (2603:10a6:803:21::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.20; Mon, 27 Sep 2021 11:22:33 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:33 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 22/25] net: dsa: felix: check return code of mdio_alloc and mdio_register Date: Mon, 27 Sep 2021 14:22:02 +0300 Message-Id: <20210927112205.301876-23-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 415e1444-d1f9-400b-df2e-08d981a919d1 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3839: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1186; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AcB2dGPZhTSOQfvyN1ysKIdbbumZWFxyEXTN2ocHBLt1lge/3M2mGlpe/tlBFKyMIoT48kEnUb86NFivhW+UoCr/canNvVcJDy2Su12EnM1CRxu4GWV0yc4t9rFIRAcPwKgdJrClqkLGh7U/h3zah++t5T5zWUfbmdEWzQi8+LfPhCQ6lplKTlm3c9SNNYheq4HHlRzU64+eYtkO4mQv7uIsPR6Nm+7LJzbOTnEu51tTOeLsYBuKcILV//yNYRpN40WzqVCeRWtopekdFy1KToaaxYhyMj8TALcKfEgfOcAKFqqJUD7BIWArYJz2QQHrOL1r9VOJG74QZnCPO5xWb+TnRNtlKE+yt2KdWPmxJQLajJuEZWxEkxAGOg/wZqhYy0TkWW8jxU6LIfd3Ea9fNUlZPchHVT33eFOP//hEdwo9epPBVS4H962+DWTqHGEAwMv3/tlNBDa6oiPmEwJc/mKWCYrwHqA6aKGh+jW7Dg6FhG+sPBWWaVOaBWadRCAGAbEKW1MZpiB7o0g5BpJgpfhANWqEmWSdeYZj8/Pds1HLHhrI1G3Jt8TklM7yAXmWUXz2Dc3OwUxVJCrAs/3V60Ir86f6BSdXIsO9YYtVhpuSgNqQYV8lQEFDrfmDRd4P2JskwpWd/H97H8aowQLpUob9eQWayDA3ftSzNZD1Vqko5uT2ZN2rbfP4xrDd+g8EQ+jgA6zQTBeIKLO5zfjgIg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6512007)(6916009)(956004)(6506007)(8676002)(38350700002)(86362001)(1076003)(38100700002)(508600001)(2906002)(54906003)(66476007)(6486002)(52116002)(36756003)(186003)(66556008)(66946007)(2616005)(5660300002)(83380400001)(26005)(6666004)(8936002)(44832011)(316002)(4326008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5Ij9RSHWCQBSswHF3q+4Q2I+oB72fupmbjuXdbrXigXiyEQhT3ULG5+RyZ/m?= =?us-ascii?Q?anv95jZpb+XxmGaNN530Ri9iEPdN84vHDfOUNcKthtfWs9dDS5slZLsFtZrc?= =?us-ascii?Q?SkqLCT5mOb55A1krjhM97kCZaWkngf2/pcHVHperWqlabCNwd6018d9FyFAO?= =?us-ascii?Q?PscW2Emol4ApMV/2qqJ3VKikTpwX8ilxKSrxesIBJz8GDSSpLwRyITMwbVJ3?= =?us-ascii?Q?IuGInIJWAXJv859tkJkiVz0NE6THBIfrn/UkOPu0/Zpved3JKN/jI5TydHy0?= =?us-ascii?Q?EdSD3n0wPYGEBhhOmagGQVEK0wDvYu2Xyvb9NerAdc9PWf/Y9dXUYip4HEhI?= =?us-ascii?Q?0fjD36T2FT4+Gp8GVFf3IS+engWoPgTUxCzZadOK7VWJ+oD0++3p/U75mQcR?= =?us-ascii?Q?e5vJkAqjDqG8nD+mkF1D+3gYg1IOEBKvQTjewYyoPBUe+EzL3PPmO4347LXd?= =?us-ascii?Q?QPhkRtvrUhJqGkEVVrnyUajVLLQwAlgHvk9ZH3ZFdZVzV5UZlHPAUniKJRFZ?= =?us-ascii?Q?OXztcSjoJYscgMqrz8QXG7IjpW+RUWyWnul2A9TYmOSUP37m1xDCOk+LCjp9?= =?us-ascii?Q?OAYbk/QrxeSrHpyyJ/lGIimenC+r/fUmlYSplL+/61kKi4MYRPXqtgaUGStU?= =?us-ascii?Q?+C0f+qeb/LWEX5cxYmUONYsuKHNYYbsn+sEs76NDDnpl61QPLd/w9iCsdzt2?= =?us-ascii?Q?L49aXATv7JCB1XRIBSoTPPubk0D3E/UcQ9mzUUwBlp/y3r9lEM/wfiUqQX4O?= =?us-ascii?Q?OGLN+daKo5641glgl+wEyP8NB2mmAWSeoNx0Tmk6aDmbs08M5gLX1i9+SJ2+?= =?us-ascii?Q?orTB9BIy8X1WKM8kKL+qow+lG++GU+wpvn5z0PI7cQHh476v3OWhaGpqV6pG?= =?us-ascii?Q?LZzpGGKf4pfN5YEvvFwC+FxPzkfdSZ2g3ULacAWbNT+8tVRy+HMPay4URSiN?= =?us-ascii?Q?rXtzV8D0sPxMxU4fmgvaKXWa7kQOdkb6wlruLvpDLbJIILkNVCa/GqMNGyPN?= =?us-ascii?Q?6SnLQ1J2ChKfrDLnGGCjggrmeeIAId2AoSI32FezRBj7HgOg0UxdAGnBojL1?= =?us-ascii?Q?nJcxpiz0Kshl5WIdPBJZwRyfBtb1286IYvZjrHcrB/vQBA5ctVOHfp9yxF4X?= =?us-ascii?Q?l1O5ZdGD/J5zb9mDAJPTSOYRcZdR+3omAPvzuIA+F9m7mhe5UneSGCIATVbb?= =?us-ascii?Q?uFjcTZxG7bkX5S7nB2KPDCD5+cJHIx4dblxvG34dh5tr5ysTBdZ+ayfZUtQy?= =?us-ascii?Q?1TXe7TMjaBYGWgZd4fXxbnHtqPpWs6IUGqb0nXdZapjxmHkOpv+1K6O4msHQ?= =?us-ascii?Q?5hSw3KyG9jx2whFcX/Y2cO+Q?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 415e1444-d1f9-400b-df2e-08d981a919d1 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:33.3985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sND0eBuITRRF3C9Wilo9siByOO9Nkf0W2i/FZ2Q+f6Z4R0Eh4Ec0Us75yXvShvzgfeuIgEf1kW0RddTOCW4FZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3839 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean These functions can return errors, it's best to catch them and trigger the driver unwind code path. Signed-off-by: Vladimir Oltean --- drivers/net/mscc_eswitch/felix_switch.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c index 4c2e57755967..98ae39e81d65 100644 --- a/drivers/net/mscc_eswitch/felix_switch.c +++ b/drivers/net/mscc_eswitch/felix_switch.c @@ -276,6 +276,7 @@ static void felix_init(struct udevice *dev) static int felix_probe(struct udevice *dev) { struct felix_priv *priv = dev_get_priv(dev); + int err; if (ofnode_valid(dev_ofnode(dev)) && !ofnode_is_available(dev_ofnode(dev))) { @@ -300,11 +301,18 @@ static int felix_probe(struct udevice *dev) struct mii_dev *mii_bus; mii_bus = mdio_alloc(); + if (!mii_bus) + return -ENOMEM; + mii_bus->read = felix_mdio_read; mii_bus->write = felix_mdio_write; mii_bus->priv = priv->imdio_base + FELIX_PM_IMDIO_BASE; strlcpy(mii_bus->name, dev->name, MDIO_NAME_LEN); - mdio_register(mii_bus); + err = mdio_register(mii_bus); + if (err) { + mdio_free(mii_bus); + return err; + } } dm_pci_clrset_config16(dev, PCI_COMMAND, 0, PCI_COMMAND_MEMORY); -- 2.25.1