From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896C7C433FE for ; Mon, 27 Sep 2021 11:28:03 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06EFC60F4B for ; Mon, 27 Sep 2021 11:28:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 06EFC60F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8B88383620; Mon, 27 Sep 2021 13:27:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="qvvvfmWg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9EE23832AD; Mon, 27 Sep 2021 13:23:22 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0613.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::613]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2210C835B9 for ; Mon, 27 Sep 2021 13:22:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nv0F+4wZPrxPWX2yP6ATOqdbtA4HFHZ34P0SatvOuiQg7nkgrHfiYdobXxBIWTVvzI32hZ3btI8yZUkCfa4BK8QG7XlmxeZ4OPmooZI3dQZ8I9uJHSRGGoLM8nZ0wrV3OtUEOxkpzwPI8/w1xIItOK03NyrXcBtMUV5YFBhUj3p7uiYQOMCvfhLXKHg7oYCbCkATuzFYyColpVa4eFKEtbVzVGAe6aD056t+Xv5vrSfElUPRYUBSKmi8sY9qKNqbGyF9CA+Ftuex+Oe4uT7XQuy4BRBRz79tNDUrwBhndiru7IaOX0vL4Tu2neA1cC0w4JVRXyzyr8pPbWNQ6qw4NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vrf+zzRb3LEu8ddaBqwAgivGI2z51Lj71EMHuaYnfvw=; b=RORs+yd7TVpNUjOKzZ4Wuk8PlO+5SqSbyTx6qoBzQEXbLiOf9+T/lt6p+U9qig/g3YQCp7zAlvJW7mum5pTBH06vNf0gkeHSOtc/PFd635QkQLaPFhZ1WAreX5I+n4+9wRlEerusjMPEuQ+Uzh3PC361UJF4VZVBnLQghHYuBtMOU3FR4tlStdAYaCLifL8jwZ/pLV0N6qLM5zyMxfMkLkGaC4Z3DCLY3MFTQU1OufuwMsOsU6pOSwuh4NXJvleWA7e+GoqhO4UJkdW0/T0kFCqva9T0W/c2hWNs6Lh3R3UMaR6KTfDVH8/OWBxUKoARt+qzm9Axj9Okp1E0eJkU5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vrf+zzRb3LEu8ddaBqwAgivGI2z51Lj71EMHuaYnfvw=; b=qvvvfmWgDDME5LQ9gubvgepsvF2sNYqiy4qI+ccI0zpIJN829YN5DRRDjxRw2aj6lmoXwhQ3+2sqFMM2Y8AJgMFCvNIJwgDTmcKmzqOt7bkuVFH+oLO7FhZurQuhxkav3A4Mbv7AQu9WsTMXQoIfW9RhWqUzYfe/8kcxPJipmVY= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB5341.eurprd04.prod.outlook.com (2603:10a6:803:3d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Mon, 27 Sep 2021 11:22:35 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:35 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 25/25] scripts: ensure the cocci script for miiphy_register does not leak the MDIO bus Date: Mon, 27 Sep 2021 14:22:05 +0300 Message-Id: <20210927112205.301876-26-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:35 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69adff63-89ec-4edb-ed5d-08d981a91b30 X-MS-TrafficTypeDiagnostic: VI1PR04MB5341: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1468; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YS7Ijj121kebu9AS16ZK1VkBtCfNZkGhP5qyghpy76nbJAlFbeJjK+LUgjJzQzGfY5nWqYCBFYaY2pLJil4XSxMN460FDel2WhLLvBECcifXxBOwlMGj0RlOfl4NTC2d3bagHWf17eXs5DGqNNukjWUIuOWhc+T2cGU7WnDrT/ch7WLq9qvaMc13HYP0TOZZtqk9AHjp46CpqZo+9o4/xuRACqf4YjcNq3XjdjK2jvIlD1sQl3ZcnWZG9RG93bw98kVH/HjiK2z7yJmbRKLAaF+JXA466D6hIZ+Gt/dvg5CrqFP4Ua5UOcdrSNxTKwxJ4OHpkOpveS4dV1og+edNwcE48/vaLxp2rra8CrqrrfYr7kMU7LqvQff7asY2KAXJtvA2p7eUxzUaD+VqHibtBwVTci6ho94AiAMze1RQeJiqnVMJDdj/7ybct0vgV02Ay3II+oDX04pZJnRDe2Jyap6CeeZiSbFntCQkAj0lqw67O9pLh394WJ7Q86UmaXLkNJ4SnM2lKRjxhPD6FQlNoi6EdZwa2Vf2EP/A82raYbMpoQ5W5OlZ7tzSt76Oo2iMmW1iPveHGYv7hpUWezUm1cjKNGeqO2bdRrENxN+Q/+knAkrTF7VpqQShjlX3o7vDhUuRZTBx6Yt98sQzO5KylBSVMX/drjpfUH8Y2rlJhb/dc1Ks86wkSN5j2DVbqGLn9CX/aA0rIxAeqPTPRjvcWA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(508600001)(6486002)(66946007)(83380400001)(66556008)(6506007)(4744005)(8676002)(1076003)(38100700002)(38350700002)(5660300002)(54906003)(66476007)(186003)(4326008)(52116002)(2616005)(6666004)(956004)(86362001)(8936002)(316002)(44832011)(36756003)(2906002)(6512007)(6916009); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?weMh4O+VFdCYyn/WDoHqcijiQuEdniLUSPtXhDRhwLY0vi3n6abIyF6nkLW6?= =?us-ascii?Q?94bq3oe39ivGWo09ck3hr8MWYUmu7gQZngUgWbb1iL5IIZAWoK2LQJcTwc9M?= =?us-ascii?Q?evAZOUrBJwx49bboPEFOY6/i3QaFK2r/Cs2c2eWfwZPy2+ljXrVmGzHuBWdP?= =?us-ascii?Q?tHOEhy87R7eV/fTYEaNOZLOPfi1pWFe/VH172UC85ZA7GZcvaaMsTuaVCQ8s?= =?us-ascii?Q?cYI/L2KVI1JIqfWOqRp+iK5wMSdpFZcTz/JCZNztskOnMRqzYcDNXypFgA7V?= =?us-ascii?Q?YKIfLT1auZfCSdQjqgY/WVHniz4pV48GX3EwpRozus5OjZ6mWL5+YQxlnJ2h?= =?us-ascii?Q?QBgd3bMJPW0Z96dvNqy+HBMKh0+8775h+GPPoJmb1i1hwhTQ5WpkzD62W5LS?= =?us-ascii?Q?tMhXcTGQdr4RPss4AW6W5R9oEjI2X0NRrT2WdiOL3rz5b0M8EvHpYam+gZWU?= =?us-ascii?Q?UpEGZ4sdSEogNzr+ABjBeto3H5rj6IpaAMW78Xrl6EtUkL7ymPgYZ/J7JSBN?= =?us-ascii?Q?pD8eAQbCwQcZtAkIvwY0ZcojImdkmfa7hjoQ2K3xfYvo7Y6GsdOrHlwHboec?= =?us-ascii?Q?YibAIDWmUi3gYxzcbiTsdzBmUhFeNhKuIoujwHOlSvJFHi1WEplrDhJx4hHv?= =?us-ascii?Q?HLt0BK/k53edvCV8wl4F2jdK07szuQ3ec+M+0brXrR4lx7s7NLZ26o7svi1R?= =?us-ascii?Q?cJvPHdujrh4mHAAXz2tuTLUNQycZXCh4oFhJ2zNsSnoLFg+HBFQ3w7BVX5y7?= =?us-ascii?Q?CcW6eHLOpCFCGoDuCSu8D1nDZqMt8rYtsFgbsb6YqWr25o8XW/UvoqaU5pst?= =?us-ascii?Q?AYMYy2jm/5CKao//9nC649hOr0gQBIYShRYflSbitAYE5WAsu1IYAcxkluac?= =?us-ascii?Q?Pqyf90D9Snem0CGpOmsy6Jfs3ug9fBSCq2G7oZejjKcR3axv2PsjZ7K6hcfS?= =?us-ascii?Q?PUbFz43MROPaXutDHQVMIkyna4y16/ntyYJLym7EwgTpQnFRLeqTBzaKAOWn?= =?us-ascii?Q?rI/pgx7CetnR/M+lJNQMG28WCV//0lolJv88l3jW+BhiUqPVh9y0nWync+KP?= =?us-ascii?Q?pCz7ZpmPpXkQs253OIsoeshzF+FAsBOHDRDFLR3JlUGyLxK9KX2hDeq/k9R1?= =?us-ascii?Q?9lpEbDLXpUGUUvbGhBgVAXWVHBmKA74XO9yj2DXKfFRZ/l5FwVPFnEPEtg84?= =?us-ascii?Q?LJLbGjhJaPOgULcHRQkrzx88DdzyjAmJQkdWI7Ym2tGa2GrnWoYoWEDOd1DG?= =?us-ascii?Q?yqEkTB7NhykLGFBvRW91bC2MjlywtdD4YKRCmEUsXx+fABx25VFH9k4RXG2X?= =?us-ascii?Q?/8lrwDe4NYQLsjxkN4j2Nayb?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69adff63-89ec-4edb-ed5d-08d981a91b30 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:35.7571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ovfMXyCIJZE769ssHZ6Ltj6qY6dR7JH3uUf4m7rb+6B+Xro+Z6zv8A3eP6CSCDeJenQZJw2tgLXStdBNq2+Ztg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5341 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean When mdio_register fails, mdio_free should be called on the mdiodev that was previously allocated with mdio_alloc. Signed-off-by: Vladimir Oltean --- scripts/coccinelle/net/mdio_register.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coccinelle/net/mdio_register.cocci b/scripts/coccinelle/net/mdio_register.cocci index 31a40360f99e..7d11281f4678 100644 --- a/scripts/coccinelle/net/mdio_register.cocci +++ b/scripts/coccinelle/net/mdio_register.cocci @@ -21,7 +21,7 @@ identifier readfunc, writefunc; + mdiodev->write = writefunc; + + retval = mdio_register(mdiodev); -+ if (retval < 0) return retval; ++ if (retval < 0) { mdio_free(mdiodev); return retval; } @ update_read_sig @ identifier mii_reg.readfunc; -- 2.25.1