From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DDDC433F5 for ; Mon, 27 Sep 2021 11:24:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57A2C60F0F for ; Mon, 27 Sep 2021 11:24:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 57A2C60F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 06CF483623; Mon, 27 Sep 2021 13:23:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="CxVxZ6Tn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1DAC783613; Mon, 27 Sep 2021 13:22:33 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on060f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::60f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 867A18348D for ; Mon, 27 Sep 2021 13:22:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jr3987Xe0lKSkhIeIt+cRvu7BnvWBOLFaMdJLT0S4jionqaqEVYJYeytEBTYJZ4x83YZZWES4BlqSS1zSSC2qLlV/lelPXe9QUBYk86d04IGOOz1TYRJVfywnCC5Wlepv4+buFOi4AUhCesMlxgKP6EPVqiwhunTdVqFy801KUw4bpyBP84zPxvD2qjz4mRh1HT+s/+PNA0CY4biFb/LAei90xiYZsS93f9IeIaJUiC+Zqlu4S41McWAVMSJMXRdiZ0l7fk+WOMzWa1zoopELxqYCsis5yNrt1EvCrRURmTuSPRoYFdok0ITRu/oZQ++SRDenD+PJtK3f+8HE/Rzng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Dp+OHx3b/L7gj4xD/qxkpUMEEG/TavQxG6zaYpyxsbU=; b=e2Krz3OM7+WqG49XXMHYaep4pN8UXgWztpcjRFQDguyJIo6gTXGpEvgABLfsZDSUUxkMeSsQb14cTgL9vRfLPrFCOtKjEDk3XD8tmPbiC7WrmT082h4o65DZ2mu3gQyhBWgXdxhR+/vM00HSH5HXimTVEwARe5lKZhE2ok2BYXAPoEfZt3UK0wjZgowxCK3SpNVNcJEBF7LWfXp0AR3RHphqZIYSnf0CJI6dxN9kknyDZK8SElkwcNESeWUeqtRO4xS3D8NZ88Y92n1lXVpwS92M2RuA4CP8POZq8xio1qFaw6fkZmHe4mc6mnBGfckukkXDVQFvuwTBj+rb26qglw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dp+OHx3b/L7gj4xD/qxkpUMEEG/TavQxG6zaYpyxsbU=; b=CxVxZ6Tn4o8c6BFN8JaK7r4D98FYOMdFldwhBB/gDsceVvkypPcsaj593ltyXEsgx+yaZfXDzHlEEbPbmPZ1v5wf9f4/jKtx0MYt9lbRs+Kktnd+z1xl4DCH66nL93xaS7EcEe+m4noZNZvUXPaP2rirTO8qh2hCOOJ7UczyJ38= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VE1PR04MB7328.eurprd04.prod.outlook.com (2603:10a6:800:1a5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Mon, 27 Sep 2021 11:22:18 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:18 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 03/25] net: armada100_fec: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation Date: Mon, 27 Sep 2021 14:21:43 +0300 Message-Id: <20210927112205.301876-4-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f99be128-c9ff-4fe3-5b6c-08d981a9110f X-MS-TrafficTypeDiagnostic: VE1PR04MB7328: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bTn6kVKT9jBwfIynX/RR3VFPZIqy88UAH5fXNPIzpvCbaGkP3NhJRqZ6HwqXeh9OUn8p+Bt466PyvjJVSztqX528rreoR2eTyvuwMt2L9TDDT3zdb7/xqP1mqJsu28NSTmS997MfZykaT9TxUvI0ZjS2QP07GWT/d19bQnjkpEKWLh3mhkdQJ0/taRLkJbVLZ+QqefS5oypzOivMRewhcl7K9aC0UxiZPwV3Z4eBpF45Mo0vKx5TT+5oLIClVGSzPrgem0KqLh+cjAxyr8n4enrKnUHgh8i02gTBhzzzIPMIIziKX7+/wFWszScoV7Cd7BZrTsSLyIUtFmnJcBXSIo5bFsh+DBhC++DMwxqAwmiZSWpobn/lsly0Bdf4U8uAsA22ShCmHUcQgI40/N9v7sB2xu2Hfe4ze5d1/g6a7Nzm3SX/oV3MvdGg3+9ONgkcfBb0vByOA4yx+dNWT2LEM7oK1LngWBmmPNq9IK8Lrg3Q0vOBh70MEHq860NLgt4dDRXzf3ZkGQVfMzTKWadx+AUpkgoRIg1EsHuAFrPds2F0hZRU9s8XUuAhyYiCAXF2Dnud2JTvMFOZK0gPO8FU3Ymo6G1WQ04rKIOfPGARp3nlrulTPNqTH3BVTZdhVudIz3DTK7YUuGhTYm4l5ph5YNtE7Mdlhme24W6TNUUzFTzgF0lCVvvERxJeUETzrGpPnIiPIdeA9KR8qzNEd4WPGg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(36756003)(316002)(186003)(956004)(86362001)(5660300002)(2616005)(54906003)(52116002)(6486002)(38100700002)(83380400001)(8936002)(4326008)(66556008)(1076003)(66946007)(8676002)(2906002)(6506007)(38350700002)(6916009)(26005)(6512007)(6666004)(508600001)(44832011)(66476007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0bvrL8CXPqBP/gYlNLc+iI2O4fadqfPBuY8LG2sZMpRIhsrbT4g9IhcdvO9L?= =?us-ascii?Q?kldBZx5q17YNg5WhFDcwmLgLiWAs9uUZrfaXNFHANSUFZUDfNB1o0Lf+c/Gf?= =?us-ascii?Q?tDqTcFK0akmTVvNGNerLwkhSTKMhaMFpaGYpi5QMzdU9Ht5SqI9aEx2GfLvl?= =?us-ascii?Q?eEXSbGugZJj9WkLo7xXZxNFWmqeal5mSneht6dZHsIDbMTuiqocpJgfhAQ8m?= =?us-ascii?Q?boxC2cThsbxOA/3yo1n0lC5XLczwLJUBQBJDJWkgAnpJfaBFqby/6z8Citca?= =?us-ascii?Q?L9eaEq3pmRQDPNrS3WcFP1MC7Ll2Rkk4Wtknbs0atXHIqp7ZSZAtGszcryy6?= =?us-ascii?Q?ie6kxB247sFZoWcXNqnMppsDDIPJxZkS0hS4fhHiVzA6bgmbO9Eexra0pLmU?= =?us-ascii?Q?O78htKB4ZDz8TSWuiNl6vpMOJPsp77n8VGL+xWqTAWCxSqOhWf9yfY6vbrj6?= =?us-ascii?Q?KEuNTThy4F8eQnGGc99ZMkItz4lvtm9LBFf3cZo0DODeK4Xt69SlTYvaKIHL?= =?us-ascii?Q?v38MSc9/wvdmVCwpYSsDQvdgMEbW2fg1JEOzplo3xE09EjP6Eqp9rm1dOBR7?= =?us-ascii?Q?9jUCzrYsQenVWVnVVH8jSsNLApNjKVo8OpGnAjAkt+MPY9PHE32FpQiTfxR2?= =?us-ascii?Q?iEvctXMenZ63FiYgzLm2OIWr6p7aV2AFOaeiKpS2i/gGulzSz1hpQaKUYaFZ?= =?us-ascii?Q?waH2XcjwDg2dsWi0NOBuN8VMBg/1LBM2gKq25vMk64ES8TrGtY5uzGsf6EEZ?= =?us-ascii?Q?shIhrP0CaIc3ydETrgMcfpGog7cQZIX72/+kKFoM4WuCFGy1hfqEpPF0iXQ4?= =?us-ascii?Q?Fcef8zFgW2kR0YBIjA7s9AhRhzqPXpleQPJXs5gQf8492DPT1ORISUV3ydRV?= =?us-ascii?Q?DuNsx123uASeZKBrYN0IX0kaDibi35Z1BydRGwHtuQsHQrrSetuCh4vOPX2U?= =?us-ascii?Q?LOOgxNiYup0usIR7wIepyP8XHbALkBed7vT7R5vgK/t20jPFJWgSttj0Dxg4?= =?us-ascii?Q?YDruTM6AS26+DOSsb9Cr95sRPCa1dZbcJNmHYttPy3MWnfhqpYrfkxu11mTD?= =?us-ascii?Q?EvFa1ClitTd8RRkUAr4jsIvJuEl4j/dwxn6ySGEcbp2G4OTAjrQYzpAOlrW+?= =?us-ascii?Q?oQG9nVZgXaqkasdtwho15fMF0wKuP4bA849bdFjWgpVTPXxitjxl59bdOiwc?= =?us-ascii?Q?8tvWoRk2jmx/L3mhZ84O1LE5ngziZn1LGZoA3BRRhpHyOMDbmNSG50P5a1ZX?= =?us-ascii?Q?Oi5lJFLdSoIvfk7OhX1SrpTp0F7q7zXp9SqeQCzNCZpdo7TOUPTyQKo324ug?= =?us-ascii?Q?1YDOVSjqIC4bZDTi39RB5nea?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f99be128-c9ff-4fe3-5b6c-08d981a9110f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:18.7090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xh+8+pqOSjyyepDGdDebyVI/dV6aW2fZvZ7+KccUbsKROL3esEaYqdndnIkoOo7jwPs0rBuLO00Cgo+DOBx9hQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7328 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more difficult to maintain. The chosen alternative is to use strlcpy(), which properly limits the copy len in the (srclen >= size) case to "size - 1", and which is also more efficient than the strncpy() byte-by-byte implementation by using memcpy. The destination string returned by strlcpy() is always NULL terminated. Signed-off-by: Vladimir Oltean --- drivers/net/armada100_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/armada100_fec.c b/drivers/net/armada100_fec.c index 018891e173c3..5d4b90c6ba72 100644 --- a/drivers/net/armada100_fec.c +++ b/drivers/net/armada100_fec.c @@ -717,7 +717,7 @@ int armada100_fec_register(unsigned long base_addr) struct mii_dev *mdiodev = mdio_alloc(); if (!mdiodev) return -ENOMEM; - strncpy(mdiodev->name, dev->name, MDIO_NAME_LEN); + strlcpy(mdiodev->name, dev->name, MDIO_NAME_LEN); mdiodev->read = smi_reg_read; mdiodev->write = smi_reg_write; -- 2.25.1