From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Paul Barker <paul.barker@sancloud.com>
Cc: u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH v3 3/3] am335x_evm_defconfig: Enable Micron SPI flash support
Date: Mon, 26 Sep 2022 15:21:33 +0200 [thread overview]
Message-ID: <21c36190-4684-d154-a439-cfabe4264097@gmx.de> (raw)
In-Reply-To: <20220921160628.4166966-4-paul.barker@sancloud.com>
On 9/21/22 18:06, Paul Barker wrote:
> Signed-off-by: Paul Barker <paul.barker@sancloud.com>
> ---
> configs/am335x_evm_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig
> index f0fbe475b394..f73123e0b71d 100644
> --- a/configs/am335x_evm_defconfig
> +++ b/configs/am335x_evm_defconfig
> @@ -92,6 +92,7 @@ CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
> CONFIG_SYS_NAND_U_BOOT_OFFS=0xc0000
> CONFIG_DM_SPI_FLASH=y
> CONFIG_SF_DEFAULT_SPEED=24000000
> +CONFIG_SPI_FLASH_STMICRO=y
You don't enable CONFIG_EFI_SPI_PROTOCOL anywhere; not even on the
sandbox. So the code is never compiled and never tested. This cannot be
correct.
Best regards
Heinrich
> CONFIG_SPI_FLASH_WINBOND=y
> CONFIG_PHY_ATHEROS=y
> CONFIG_PHY_SMSC=y
next prev parent reply other threads:[~2022-09-26 13:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 16:06 [PATCH v3 0/3] Support UEFI SPI I/O protocol Paul Barker
2022-09-21 16:06 ` [PATCH v3 1/3] efi_loader: Add SPI I/O protocol support Paul Barker
2022-09-26 12:43 ` Ilias Apalodimas
2022-09-26 13:13 ` Heinrich Schuchardt
2022-09-26 13:40 ` Ilias Apalodimas
2022-10-03 12:05 ` Paul Barker
2022-10-03 12:00 ` Paul Barker
2022-09-26 13:52 ` Heinrich Schuchardt
2022-10-03 12:05 ` Paul Barker
2022-10-04 16:31 ` Paul Barker
2022-10-04 17:25 ` Heinrich Schuchardt
2022-09-21 16:06 ` [PATCH v3 2/3] arm: dts: am335x-sancloud-bbe-lite: UEFI SPI export Paul Barker
2022-09-21 16:15 ` Tom Rini
2022-09-26 11:33 ` Ilias Apalodimas
2022-09-26 13:13 ` Tom Rini
2022-09-26 13:33 ` Heinrich Schuchardt
2022-09-26 19:13 ` Tom Rini
2022-09-21 16:06 ` [PATCH v3 3/3] am335x_evm_defconfig: Enable Micron SPI flash support Paul Barker
2022-09-26 13:21 ` Heinrich Schuchardt [this message]
2022-10-03 12:07 ` Paul Barker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21c36190-4684-d154-a439-cfabe4264097@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=ilias.apalodimas@linaro.org \
--cc=paul.barker@sancloud.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).