Re: [PATCH v2 u-boot-mvebu 4/4] arm: mvebu: clearfog: Update eMMC/SD/SATA instructions

[Stefan Roese <sr@denx.de>]

Hi Eugen,

On 5/3/23 11:43, Eugen Hristev wrote:
> On 5/3/23 12:17, Stefan Roese wrote:
>> On 4/29/23 13:08, Pali Rohár wrote:
>>> On Thursday 27 April 2023 10:56:17 Stefan Roese wrote:
>>>> Hi Pali,
>>>>
>>>> On 4/27/23 01:44, Pali Rohár wrote:
>>>>> On Thursday 13 April 2023 22:43:25 Martin Rowe wrote:
>>>>>> On Thu, 13 Apr 2023 at 20:58, Pali Rohár <pali@kernel.org> wrote:
>>>>>>>
>>>>>>> BootROM and neither SPL does not use eMMC boot acknowledgement or 
>>>>>>> boot
>>>>>>> enable bits in EXT_CSD_PART_CONF eMMC register. And also fixed 
>>>>>>> SATA disk
>>>>>>> sector 0x141 is not used at all.
>>>>>>>
>>>>>>> Signed-off-by: Pali Rohár <pali@kernel.org>
>>>>>>
>>>>>> SPL successfully loads u-boot from the same partition as SPL. SD card
>>>>>> and UART continue to boot.
>>>>>>
>>>>>> Thanks Pali!
>>>>>>
>>>>>> Tested-by: Martin Rowe <martin.p.rowe@gmail.com>
>>>>>
>>>>> Ok, is something more needed for this patch series?
>>>>
>>>> Unfortunately yes. As at least this board breaks with this patchset
>>>> added:
>>>>
>>>> $ make sama5d2_icp_mmc_defconfig
>>>> $ make -sj
>>>> /opt/kernel.org/gcc-12.2.0-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-ld.bfd:
>>>> u-boot-spl section `__u_boot_list' will not fit in region `.sram'
>>>> /opt/kernel.org/gcc-12.2.0-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-ld.bfd:
>>>> region `.sram' overflowed by 32 bytes
>>>> make[1]: *** [scripts/Makefile.spl:527: spl/u-boot-spl] Error 1
>>>> make: *** [Makefile:2049: spl/u-boot-spl] Error 2
>>>>
>>>> So CI build fails and I can't send a pull request. I'm sending a patch
>>>> though, to fix this image overflow by enabling LTO. Stay tuned...
>>>
>>> I see... LTO helped. So can be this patch series now applied?
>>
>> No problems with this series now in master, so:
>>
>> Applied to u-boot-marvell/master
> 
> Hi Stefan,
> 
> This patch is still pending as it was not tested by anyone yet :
> 
> https://patchwork.ozlabs.org/project/uboot/patch/20230427085945.475619-1-sr@denx.de/
> 
> so , this series still breaks the sama5d2_icp board ?

No. Azure CI build has run w/o any problems. Otherwise I would not have
been able to send a pull request for these patches.

Thanks,
Stefan

> Thanks,
> Eugen
> 
>>
>> Thanks,
>> Stefan
>>
>>>> Thanks,
>>>> Stefan
>>>>
>>>>>>> ---
>>>>>>>    board/solidrun/clearfog/README | 20 ++++++++++----------
>>>>>>>    1 file changed, 10 insertions(+), 10 deletions(-)
>>>>>>>
>>>>>>> diff --git a/board/solidrun/clearfog/README 
>>>>>>> b/board/solidrun/clearfog/README
>>>>>>> index ed4a712c5aa2..c86b37061a30 100644
>>>>>>> --- a/board/solidrun/clearfog/README
>>>>>>> +++ b/board/solidrun/clearfog/README
>>>>>>> @@ -1,7 +1,7 @@
>>>>>>>    Update from original Marvell U-Boot to mainline U-Boot:
>>>>>>>    -------------------------------------------------------
>>>>>>>
>>>>>>> -Generate the U-Boot image with these commands:
>>>>>>> +Generate the U-Boot image for eMMC/SD with these commands:
>>>>>>>
>>>>>>>    $ make clearfog_defconfig
>>>>>>>    $ make
>>>>>>> @@ -9,7 +9,7 @@ $ make
>>>>>>>    The resulting image including the SPL binary with the
>>>>>>>    full DDR setup is "u-boot-with-spl.kwb".
>>>>>>>
>>>>>>> -Now all you need to do is copy this image on a SD card.
>>>>>>> +Now all you need to do is copy this image on a SD card's sector 1.
>>>>>>>    For example with this command:
>>>>>>>
>>>>>>>    $ sudo dd if=u-boot-with-spl.kwb of=/dev/sdX bs=512 seek=1
>>>>>>> @@ -20,12 +20,6 @@ of "/dev/sdX" here!
>>>>>>>    Install U-Boot on eMMC:
>>>>>>>    -----------------------
>>>>>>>
>>>>>>> -To make SPL load the main U-Boot image from the eMMC boot 
>>>>>>> partition enable
>>>>>>> -eMMC boot acknowledgement and boot partition with the following 
>>>>>>> U-Boot
>>>>>>> -command:
>>>>>>> -
>>>>>>> -  mmc partconf 0 1 1 0
>>>>>>> -
>>>>>>>    Install U-Boot on eMMC boot partition from Linux running on 
>>>>>>> Clearfog:
>>>>>>>
>>>>>>>      echo 0 > /sys/block/mmcblk0boot0/force_ro
>>>>>>> @@ -37,8 +31,14 @@ Consider initial boot from UART (see below).
>>>>>>>    Install U-Boot on SATA:
>>>>>>>    -----------------------
>>>>>>>
>>>>>>> -When loading the main U-Boot image from raw SATA sector, set
>>>>>>> -CONFIG_SPL_SATA_RAW_U_BOOT_SECTOR to 0x141.
>>>>>>> +Generate the U-Boot image for SATA with these commands:
>>>>>>> +
>>>>>>> +$ make clearfog_sata_defconfig
>>>>>>> +$ make
>>>>>>> +
>>>>>>> +Copy image on a SATA disk's sector 1:
>>>>>>> +
>>>>>>> +$ sudo dd if=u-boot-with-spl.kwb of=/dev/sdX bs=512 seek=1
>>>>>>>
>>>>>>>    Boot selection:
>>>>>>>    ---------------
>>>>>>> -- 
>>>>>>> 2.20.1
>>>>>>>
>>>>
>>>> Viele Grüße,
>>>> Stefan Roese
>>>>
>>>> -- 
>>>> DENX Software Engineering GmbH,      Managing Director: Erika Unter
>>>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>>> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
>>
>> Viele Grüße,
>> Stefan Roese
>>
> 

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de