From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Simon Glass <sjg@chromium.org>,
U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Bin Meng <bmeng.cn@gmail.com>,
Christian Melki <christian.melki@t2data.com>,
Tom Rini <trini@konsulko.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH v2 10/39] x86: Create a 32/64-bit selection for the app
Date: Sat, 23 Oct 2021 13:41:31 +0200 [thread overview]
Message-ID: <924fd6b1-2819-409d-b6d5-1589d7aa26b5@gmx.de> (raw)
In-Reply-To: <20210924183029.v2.10.Id32ab4eff4b2a6b82fed22813a01fc2a08c6e0a5@changeid>
On 9/25/21 02:30, Simon Glass wrote:
> Most EFI implementations use 64-bit but U-Boot only supports running as
> a 32-bit app at present. While efi-x86_payload64 does boot from 64-bit
> UEFI it immediately changes back to 32-bit before starting U-Boot.
>
> In order to support a 64-bit U-Boot app, update the Kconfig to add an
> option for 32/64 bit. Update the prompt for the existing option so it is
> clear it relates to the stub. Move both up to just under the choice that
> controls them, since this looks better and the menu.
>
> Use CONFIG_EFI_APP in the Makefile instead of CONFIG_TARGET_EFI_APP,
> since the latter is specific to a single target and we will have two.
>
> Memory size is set to 32MB for now so that it can run on qemu without
> increasing the default memory size. We may need to increase the default
> later.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2:
> - Expand the commit message to make things clearer
>
> arch/x86/cpu/intel_common/Makefile | 2 +-
> lib/efi/Kconfig | 34 +++++++++++++++++++++++-------
> 2 files changed, 27 insertions(+), 9 deletions(-)
>
> diff --git a/arch/x86/cpu/intel_common/Makefile b/arch/x86/cpu/intel_common/Makefile
> index 8b9a810f66d..1dc17b45879 100644
> --- a/arch/x86/cpu/intel_common/Makefile
> +++ b/arch/x86/cpu/intel_common/Makefile
> @@ -27,7 +27,7 @@ obj-y += fast_spi.o
> obj-y += lpc.o
> obj-y += lpss.o
> obj-$(CONFIG_$(SPL_)INTEL_GENERIC_WIFI) += generic_wifi.o
> -ifndef CONFIG_TARGET_EFI_APP
> +ifndef CONFIG_EFI_APP
> obj-$(CONFIG_$(SPL_TPL_)X86_32BIT_INIT) += microcode.o
> ifndef CONFIG_$(SPL_)X86_64
> obj-y += microcode.o
> diff --git a/lib/efi/Kconfig b/lib/efi/Kconfig
> index 93b85644920..e818cef0d15 100644
> --- a/lib/efi/Kconfig
> +++ b/lib/efi/Kconfig
> @@ -26,18 +26,26 @@ config EFI_STUB
>
> endchoice
>
> -config EFI_RAM_SIZE
> - hex "Amount of EFI RAM for U-Boot"
> +choice
> + prompt "EFI app 32/64-bit selection"
> depends on EFI_APP
> - default 0x2000000
> help
> - Set the amount of EFI RAM which is claimed by U-Boot for its own
> - use. U-Boot allocates this from EFI on start-up (along with a few
> - other smaller amounts) and it can never be increased after that.
> - It is used as the RAM size in with U-Boot.
> + EFI does not support mixing 32-bit and 64-bit modes. This is a
> + significant problem because it means that you must build a stub with
> + the correct type for EFI to load it correctly. If you are using
> + 32-bit EFI, select 32-bit here, else select 64-bit. Failure to do
> + this may produce no error message - it just won't start!
> +
> +config EFI_APP_32BIT
> + bool "Produce an app for running with 32-bit EFI"
> +
> +config EFI_APP_64BIT
> + bool "Produce an app for running with 64-bit EFI"
> +
> +endchoice
>
> choice
> - prompt "EFI 32/64-bit selection"
> + prompt "EFI stub 32/64-bit selection"
> depends on EFI_STUB
> help
> EFI does not support mixing 32-bit and 64-bit modes. This is a
> @@ -53,3 +61,13 @@ config EFI_STUB_64BIT
> bool "Produce a stub for running with 64-bit EFI"
>
> endchoice
> +
> +config EFI_RAM_SIZE
> + hex "Amount of EFI RAM for U-Boot"
> + depends on EFI_APP
> + default 0x2000000
This will be too small for loading the kernel and the initrd in some
cases. 256 MiB seems reasonable.
Best regards
Heinrich
> + help
> + Set the amount of EFI RAM which is claimed by U-Boot for its own
> + use. U-Boot allocates this from EFI on start-up (along with a few
> + other smaller amounts) and it can never be increased after that.
> + It is used as the RAM size in with U-Boot.
>
next prev parent reply other threads:[~2021-10-23 11:41 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 0:30 [PATCH v2 00/39] efi: Improvements to U-Boot running on top of UEFI Simon Glass
2021-09-25 0:30 ` [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Simon Glass
2021-10-20 23:34 ` Heinrich Schuchardt
2022-10-14 11:51 ` Jan Kiszka
2022-10-14 13:13 ` Tom Rini
2022-10-14 15:33 ` Simon Glass
2022-10-14 15:34 ` Jan Kiszka
2022-10-14 15:36 ` Simon Glass
2022-10-14 15:39 ` Tom Rini
2022-10-14 15:47 ` Jan Kiszka
2022-10-14 15:58 ` Tom Rini
2022-10-14 15:10 ` Heinrich Schuchardt
2022-10-14 15:20 ` Tom Rini
2022-10-14 15:27 ` Jan Kiszka
2022-10-14 15:34 ` Tom Rini
2022-10-14 15:35 ` Jan Kiszka
2022-10-14 15:38 ` Tom Rini
2022-10-14 15:25 ` Jan Kiszka
2021-09-25 0:30 ` [PATCH v2 02/39] efi: Add a separate maintainer entry for the app Simon Glass
2021-10-18 16:36 ` Heinrich Schuchardt
2021-09-25 0:30 ` [PATCH v2 03/39] x86: Keep symbol information in u-boot ELF file Simon Glass
2021-09-25 0:30 ` [PATCH v2 04/39] x86: Create a new header for EFI Simon Glass
2021-10-18 17:00 ` Heinrich Schuchardt
2021-09-25 0:30 ` [PATCH v2 05/39] x86: Show some EFI info with the bdinfo command Simon Glass
2021-10-18 17:10 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 06/39] x86: Tidy up global_data pointer for 64-bit Simon Glass
2021-10-18 17:15 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 07/39] efi: Add a script for building and testing U-Boot on UEFI Simon Glass
2021-10-18 17:30 ` Heinrich Schuchardt
2021-10-18 18:12 ` Simon Glass
2021-10-25 19:35 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 08/39] efi: Enable DM_ETH for the app Simon Glass
2021-09-25 0:30 ` [PATCH v2 09/39] efi: Drop the OF_EMBED warning for EFI Simon Glass
2021-10-23 11:37 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 10/39] x86: Create a 32/64-bit selection for the app Simon Glass
2021-10-23 11:41 ` Heinrich Schuchardt [this message]
2021-09-25 0:30 ` [PATCH v2 11/39] efi: Create a 64-bit app Simon Glass
2021-09-25 0:30 ` [PATCH v2 12/39] x86: Don't duplicate global_ptr in 64-bit EFI app Simon Glass
2021-09-25 0:30 ` [PATCH v2 13/39] efi: Add a way to obtain boot services in the app Simon Glass
2021-09-25 0:30 ` [PATCH v2 14/39] efi: Add video support to " Simon Glass
2021-09-25 0:30 ` [PATCH v2 15/39] efi: Add EFI uclass for media Simon Glass
2021-10-23 12:26 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 16/39] efi: Add a media/block driver for EFI block devices Simon Glass
2021-09-25 0:30 ` [PATCH v2 17/39] efi: Locate all block devices in the app Simon Glass
2021-09-25 0:30 ` [PATCH v2 18/39] patman: Use a ValueError exception if tools.Run() fails Simon Glass
2021-09-25 0:30 ` [PATCH v2 19/39] binman: Report an error if test files fail to compile Simon Glass
2021-09-25 0:30 ` [PATCH v2 20/39] binman: Support reading the offset of an ELF-file symbol Simon Glass
2021-09-25 0:30 ` [PATCH v2 21/39] binman: Allow timeout to occur in the image or its section Simon Glass
2021-09-25 0:30 ` [PATCH v2 22/39] binman: Tidy up comments on _DoTestFile() Simon Glass
2021-09-25 0:30 ` [PATCH v2 23/39] binman: Support updating the dtb in an ELF file Simon Glass
2021-09-25 0:30 ` [PATCH v2 24/39] efi: serial: Support arrow keys Simon Glass
2021-10-18 16:55 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 25/39] bloblist: Support allocating the bloblist Simon Glass
2021-09-25 0:30 ` [PATCH v2 26/39] x86: Allow booting a kernel from the EFI app Simon Glass
2021-09-25 0:30 ` [PATCH v2 27/39] x86: Don't process the kernel command line unless enabled Simon Glass
2021-09-25 0:30 ` [PATCH v2 28/39] x86: efi: Add room for the binman definition in the dtb Simon Glass
2021-09-25 0:30 ` [PATCH v2 29/39] efi: Add comments to struct efi_priv Simon Glass
2021-10-23 11:28 ` Heinrich Schuchardt
2021-09-25 0:30 ` [PATCH v2 30/39] efi: Fix ll_boot_init() operation with the app Simon Glass
2021-09-25 0:30 ` [PATCH v2 32/39] efi: Share struct efi_priv between the app and stub code Simon Glass
2021-09-25 0:30 ` [PATCH v2 33/39] efi: Move exit_boot_services into a function Simon Glass
2021-09-25 0:30 ` [PATCH v2 34/39] efi: Check for failure when initing the app Simon Glass
2021-09-25 0:30 ` [PATCH v2 35/39] efi: Mention that efi_info_get() is only used in the stub Simon Glass
2021-09-25 0:30 ` [PATCH v2 36/39] efi: Show when allocated pages are used Simon Glass
2021-09-25 0:30 ` [PATCH v2 37/39] efi: Allow easy selection of serial-only operation Simon Glass
2021-09-25 0:30 ` [PATCH v2 38/39] efi: Update efi_get_next_mem_desc() to avoid needing a map Simon Glass
2021-09-25 0:30 ` [PATCH v2 39/39] efi: Support the efi command in the app Simon Glass
2021-10-18 15:25 ` [PATCH v2 00/39] efi: Improvements to U-Boot running on top of UEFI Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=924fd6b1-2819-409d-b6d5-1589d7aa26b5@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=bmeng.cn@gmail.com \
--cc=christian.melki@t2data.com \
--cc=ilias.apalodimas@linaro.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).