From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Tom Rini <trini@konsulko.com>,
Mayuresh Chitale <mchitale@ventanamicro.com>
Cc: Bin Meng <bmeng.cn@gmail.com>, Simon Glass <sjg@chromium.org>,
u-boot@lists.denx.de, Rick Chen <rick@andestech.com>,
Leo <ycliang@andestech.com>
Subject: Re: [PATCH v3 4/5] spl: Support loading a FIT from ext FS
Date: Wed, 17 May 2023 16:58:17 +0200 [thread overview]
Message-ID: <BB3F2515-4EB9-4231-A4C6-41B1290B25EE@gmx.de> (raw)
In-Reply-To: <20230517144147.GA3595985@bill-the-cat>
Am 17. Mai 2023 16:41:47 MESZ schrieb Tom Rini <trini@konsulko.com>:
>On Thu, May 04, 2023 at 03:23:26PM +0530, Mayuresh Chitale wrote:
>
>> Detect a FIT when loading from an ext File system and handle it using
>> the FIT SPL support.
>>
>> Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
>> ---
>> common/spl/spl_ext.c | 33 +++++++++++++++++++++++++++++++++
>> 1 file changed, 33 insertions(+)
>>
>> diff --git a/common/spl/spl_ext.c b/common/spl/spl_ext.c
>> index f117c630bf..7b771c41e9 100644
>> --- a/common/spl/spl_ext.c
>> +++ b/common/spl/spl_ext.c
>> @@ -8,6 +8,26 @@
>> #include <ext4fs.h>
>> #include <errno.h>
>> #include <image.h>
>> +#include <linux/libfdt.h>
>> +
>> +static ulong spl_fit_read(struct spl_load_info *load, ulong file_offset,
>> + ulong size, void *buf)
>> +{
>> + loff_t filelen = (loff_t)load->priv, actlen;
The comma seems to be incorrect.
>> + char *filename = (char *)load->filename;
>
>Please build on 32bit platforms such as j721e_evm_r5 as well:
>+common/spl/spl_ext.c:16:26: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>+ 16 | loff_t filelen = (loff_t)load->priv, actlen;
>
next prev parent reply other threads:[~2023-05-17 14:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 9:53 [PATCH v3 0/5] SPL NVMe support Mayuresh Chitale
2023-05-04 9:53 ` [PATCH v3 1/5] spl: Add Kconfig options for NVME Mayuresh Chitale
2023-05-05 0:41 ` Simon Glass
2023-05-04 9:53 ` [PATCH v3 2/5] spl: blk: Support loading images from fs Mayuresh Chitale
2023-05-05 0:41 ` Simon Glass
2023-06-03 8:19 ` Mayuresh Chitale
2023-05-04 9:53 ` [PATCH v3 3/5] nvme: pci: Enable for SPL Mayuresh Chitale
2023-05-05 0:41 ` Simon Glass
2023-06-03 8:19 ` Mayuresh Chitale
2023-05-04 9:53 ` [PATCH v3 4/5] spl: Support loading a FIT from ext FS Mayuresh Chitale
2023-05-05 0:40 ` Simon Glass
2023-06-03 8:21 ` Mayuresh Chitale
2023-05-17 14:41 ` Tom Rini
2023-05-17 14:58 ` Heinrich Schuchardt [this message]
2023-06-03 8:22 ` Mayuresh Chitale
2023-05-04 9:53 ` [PATCH v3 5/5] common: spl: Add spl NVMe boot support Mayuresh Chitale
2023-05-05 0:40 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BB3F2515-4EB9-4231-A4C6-41B1290B25EE@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=bmeng.cn@gmail.com \
--cc=mchitale@ventanamicro.com \
--cc=rick@andestech.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).