Re: [PATCH 2/4] efi_loader: function to get GUID for variable name

From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	AKASHI Takahiro <takahiro.akashi@linaro.org>,
	 Sughosh Ganu <sughosh.ganu@linaro.org>,
	Masahisa Kojima <masahisa.kojima@linaro.org>,
	 Alexander Graf <agraf@csgraf.de>
Subject: Re: [PATCH 2/4] efi_loader: function to get GUID for variable name
Date: Sat, 11 Sep 2021 17:21:22 +0300	[thread overview]
Message-ID: <CAC_iWj+N-RodTPHzWsLXQ6n7Qj+Hjx9eZ8V75t_-OHUJh7u4qQ@mail.gmail.com> (raw)
In-Reply-To: <YTy5bxXAIPE5xbP+@apalos.home>

On Sat, 11 Sept 2021 at 17:13, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> On Sat, Sep 11, 2021 at 09:28:30AM +0200, Heinrich Schuchardt wrote:
> > In multiple places we need the default GUID used for variables like
> > 'PK', 'KEK', 'db'. Provide a function for it.
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > ---
> >  include/efi_variable.h          | 8 ++++++++
> >  lib/efi_loader/efi_var_common.c | 9 +++++++++
> >  2 files changed, 17 insertions(+)
> >
> > diff --git a/include/efi_variable.h b/include/efi_variable.h
> > index 8f666b2309..03a3ecb235 100644
> > --- a/include/efi_variable.h
> > +++ b/include/efi_variable.h
> > @@ -256,6 +256,14 @@ efi_status_t efi_init_secure_state(void);
> >  enum efi_auth_var_type efi_auth_var_get_type(const u16 *name,
> >                                            const efi_guid_t *guid);
> >
> > +/**
> > + * efi_auth_var_get_guid() - get the predefined GUID for a variable name
> > + *
> > + * @name:    name of UEFI variable
> > + * Return:   guid of UEFI variable
> > + */
> > +const efi_guid_t *efi_auth_var_get_guid(const u16 *name);
> > +
> >  /**
> >   * efi_get_next_variable_name_mem() - Runtime common code across efi variable
> >   *                                    implementations for GetNextVariable()
> > diff --git a/lib/efi_loader/efi_var_common.c b/lib/efi_loader/efi_var_common.c
> > index e179932124..3cbb7c96c2 100644
> > --- a/lib/efi_loader/efi_var_common.c
> > +++ b/lib/efi_loader/efi_var_common.c
> > @@ -385,6 +385,15 @@ enum efi_auth_var_type efi_auth_var_get_type(const u16 *name,
> >       return EFI_AUTH_VAR_NONE;
> >  }
> >
> > +const efi_guid_t *efi_auth_var_get_guid(const u16 *name)
> > +{
> > +     for (size_t i = 0; i < ARRAY_SIZE(name_type); ++i) {
> > +             if (!u16_strcmp(name, name_type[i].name))
> > +                     return name_type[i].guid;
> > +     }
> > +     return &efi_global_variable_guid;

Actually looking at the following patch, shouldn't this be NULL?

> > +}
> > +
> >  /**
> >   * efi_get_var() - read value of an EFI variable
> >   *
> > --
> > 2.30.2
> >
>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>