Re: [PATCH 1/4] riscv: sophgo: milkv_duo: initial support added

[刘孔阳 <seashell11234455@gmail.com>]

Tom Rini <trini@konsulko.com> 于2024年1月9日周二 04:42写道：
>
> On Sun, Jan 07, 2024 at 07:27:07PM +0800, Kongyang Liu wrote:
>
> > Add support for Sophgo's Milk-V Duo board, only minimal device tree and
> > serial console are enabled, and it can boot via vendor first stage
> > bootloader.
> >
> > Signed-off-by: Kongyang Liu <seashell11234455@gmail.com>
> >
> > ---
> >
> >  arch/riscv/Kconfig                 |  4 ++++
> >  board/sophgo/milkv_duo/Kconfig     | 28 ++++++++++++++++++++++++++++
> >  board/sophgo/milkv_duo/MAINTAINERS |  6 ++++++
> >  board/sophgo/milkv_duo/Makefile    |  5 +++++
> >  board/sophgo/milkv_duo/board.c     |  9 +++++++++
> >  include/configs/milkv_duo.h        | 16 ++++++++++++++++
>
> The defconfig patch should be folded in to this one.
>
I will fold it in next version.

> [snip]
> > diff --git a/board/sophgo/milkv_duo/board.c b/board/sophgo/milkv_duo/board.c
> > new file mode 100644
> > index 0000000000..eaa47be173
> > --- /dev/null
> > +++ b/board/sophgo/milkv_duo/board.c
> > @@ -0,0 +1,9 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (c) 2024, Kongyang Liu <seashell11234455@gmail.com>
> > + */
> > +
> > +int board_init(void)
> > +{
> > +     return 0;
> > +}
>
> Shouldn't you enable caches here?
>
Enable caches will cause other problems, and I will implement it
in subsequent patches.

> > diff --git a/include/configs/milkv_duo.h b/include/configs/milkv_duo.h
> > new file mode 100644
> > index 0000000000..dd1d146c50
> > --- /dev/null
> > +++ b/include/configs/milkv_duo.h
> > @@ -0,0 +1,16 @@
> > +/* SPDX-License-Identifier: GPL-2.0+ */
> > +/*
> > + * Copyright (c) 2024, Kongyang Liu <seashell11234455@gmail.com>
> > + *
> > + */
> > +
> > +#ifndef __CONFIG_H
> > +#define __CONFIG_H
> > +
> > +#define CFG_SYS_SDRAM_BASE         0x80000000
> > +
> > +#define CFG_EXTRA_ENV_SETTINGS                 \
> > +     "consoledev=ttyS0"                         \
> > +     "baudrate=115200\0"                        \
>
> We shouldn't need to set baudrate, it will be handled for us. Is
> consoledev something that must be set? Can it all be done in a plain
> text environment anyhow? Thanks.
>
I will check and detele it if it is unnecessary.

Best regards
Kongyang Liu
> --
> Tom