Re: The latest U-boot reports an error when running on StarFive visionfive2 1.3B board

From: Simon Glass <sjg@chromium.org>
To: yanhong wang <yanhong.wang@starfivetech.com>
Cc: u-boot@lists.denx.de, Rick Chen <rick@andestech.com>,
	Leo <ycliang@andestech.com>, Torsten Duwe <duwe@lst.de>
Subject: Re: The latest U-boot reports an error when running on StarFive visionfive2 1.3B board
Date: Fri, 2 Jun 2023 19:05:49 -0600	[thread overview]
Message-ID: <CAPnjgZ3G0q=6KSKHCc-1aeLXebaiN4cfvzrtOfv9R6tYpM5iNg@mail.gmail.com> (raw)
In-Reply-To: <87df93fb-38b0-d293-c2cf-cf887e275130@starfivetech.com>

Hi,

On Thu, 1 Jun 2023 at 19:16, yanhong wang <yanhong.wang@starfivetech.com> wrote:
>
>
>
> On 2023/5/31 2:11, Simon Glass wrote:
> > Hi Yanhong,
> >
> > Please can you send this to the mailing list and cc me?
> >
> > Regards,
> > Simon
> >
> > On Tue, 16 May 2023 at 20:48, yanhong wang
> > <yanhong.wang@starfivetech.com> wrote:
> >>
> >> Hi Simon Glass,
> >>
> >> Running the latest U-boot on the StarFive VisionFive 2 1.3B board prompts the following error message:
> >>
> >> U-Boot 2023.07-rc2-00133-g6e1852ca2c (May 17 2023 - 09:08:48 +0800)
> >>
> >> CPU:   rv64imafdc_zba_zbb
> >> Model: StarFive VisionFive 2 v1.3B
> >> DRAM:  8 GiB
> >> initcall sequence 00000000fffe08b0 failed at call 000000004021611e (err=-19)
> >> ### ERROR ### Please RESET the board ###
> >>
> >> Roll back the most recent submission, and finally confirm that one of the submission affected [commit ID: 55171aedda88d12666e2a1bbc661dea1bec65337].
> >> The author of this submission is you, so I sent this email to learn more about the specific situation.
> >>
> >> Do you have any suggestions to solution this issue?

$ ./scripts/event_dump.py /tmp/b/starfive_visionfive2/u-boot
Event type            Id                              Source location
--------------------  ------------------------------
------------------------------
EVT_DM_POST_INIT_F    f:.text_rest                    arch/riscv/cpu/cpu.c:95
EVT_FT_FIXUP          f:bootmeth_vbe_ft_fixup         boot/vbe_request.c:153
EVT_FT_FIXUP          f:bootmeth_vbe_simple_ft_fixup  boot/vbe_simple_os.c:54

Looking at the first line, it is calling riscv_cpu_setup(). I'm not
sure why it is failing now, but didn't before, since the commit drops
the post-relocation call, leaving just the pre-relocation call. Is
this failing before or after relocation? (GD_FLAG_RELOC)

But you should look at why riscv_cpu_setup() needs to be called before
relocation and whether the CPU nodes in the devicetree need a
bootph-pre-ram property as per [1].

Regards,
Simon

[1] https://u-boot.readthedocs.io/en/latest/develop/driver-model/design.html?highlight=bootph-pre-ram#pre-relocation-support