u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Alexander Graf <agraf@csgraf.de>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
	Sunny Wang <Sunny.Wang@arm.com>
Subject: RE: [PATCH 1/1] efi_loader: TPL_HIGH_LEVEL not allowed for CreateEvent
Date: Fri, 11 Jun 2021 16:19:47 +0000	[thread overview]
Message-ID: <PAXPR08MB698723DB43861DF458C0DCB590349@PAXPR08MB6987.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210610212558.23333-1-xypron.glpk@gmx.de>

Acked-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: Thursday, June 10, 2021 5:26 PM
> To: Alexander Graf <agraf@csgraf.de>
> Cc: u-boot@lists.denx.de; Heinrich Schuchardt <xypron.glpk@gmx.de>;
> Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Subject: [PATCH 1/1] efi_loader: TPL_HIGH_LEVEL not allowed for
> CreateEvent
>
> According to chapter 7.1 "Event, Timer, and Task Priority Services"
> TPL_HIGH_LEVEL should not be exposed to applications and drivers.
>
> According to the discussion with EDK II contributors this implies that
> CreateEvent() shall not allow to create events with TPL_HIGH_LEVEL.
>
> Cf. https://edk2.groups.io/g/devel/message/76337
>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  lib/efi_loader/efi_boottime.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
> index 4777b35fd4..f6d5ba05e3 100644
> --- a/lib/efi_loader/efi_boottime.c
> +++ b/lib/efi_loader/efi_boottime.c
> @@ -264,7 +264,6 @@ efi_status_t is_valid_tpl(efi_uintn_t tpl)
>       case TPL_APPLICATION:
>       case TPL_CALLBACK:
>       case TPL_NOTIFY:
> -     case TPL_HIGH_LEVEL:
>               return EFI_SUCCESS;
>       default:
>               return EFI_INVALID_PARAMETER;
> --
> 2.30.2

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

      reply	other threads:[~2021-06-11 17:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10 21:25 [PATCH 1/1] efi_loader: TPL_HIGH_LEVEL not allowed for CreateEvent Heinrich Schuchardt
2021-06-11 16:19 ` Samer El-Haj-Mahmoud [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PAXPR08MB698723DB43861DF458C0DCB590349@PAXPR08MB6987.eurprd08.prod.outlook.com \
    --to=samer.el-haj-mahmoud@arm.com \
    --cc=Sunny.Wang@arm.com \
    --cc=agraf@csgraf.de \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).