On 03/10/2022 13:05, Paul Barker wrote: > On 26/09/2022 14:52, Heinrich Schuchardt wrote: >> On 9/21/22 18:06, Paul Barker wrote: >>> + >>> +    log_debug("Added EFI_SPI_IO_PROTOCOL for %s with guid " >>> +          "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x\n", >>> +          name, >>> +          guid->b[3], guid->b[2], guid->b[1], guid->b[0], >>> +          guid->b[5], guid->b[4], guid->b[7], guid->b[6], >>> +          guid->b[8], guid->b[9], guid->b[10], guid->b[11], >>> +          guid->b[12], guid->b[13], guid->b[14], guid->b[15]); >>> +    return EFI_SUCCESS; >> >> This should be >> >> log_debug(Added EFI_SPI_IO_PROTOCOL for %s with guid %pD\n", guid); > > I'll address this in v4. After a quick look in lib/vsprintf.c, I assume you meant %pUl here. Thanks, -- Paul Barker Principal Software Engineer SanCloud Ltd e: paul.barker@sancloud.com w: https://sancloud.com/