Re: [PATCH v6 00/11] board: toradex: verdin-imx8mm: target refresh

[Marcel Ziswiler <marcel.ziswiler@toradex.com>]

Hi Tim

On Tue, 2021-10-12 at 12:46 -0700, Tim Harvey wrote:
> On Sat, Oct 9, 2021 at 1:43 PM Marcel Ziswiler <marcel@ziswiler.com> wrote:
> > 
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > 
> > 
> > An assortment of fixes and improvements like an Ethernet PHY
> > configuration fix, DEK blob encapsulation preparation, migration to
> > using binman to pack images, SLEEP_MOCI# enablement, dropping of V1.0
> > hardware support [1], renaming kernel image variable, using preboot
> > for fdtfile evaluation and watchdog pinctrl fix.
> > 
> > Note that this series is applied on top of Peng's Makefile fix [2] as
> > otherwise, it may not quite generate all binman artefacts in the right
> > order as discussed here [3].
> > 
> > [1] https://developer.toradex.com/verdin-sample-phase-over
> > [2] https://marc.info/?l=u-boot&m=162908373904742
> > [3] https://marc.info/?l=u-boot&m=162945614207220
> > 
> > Changes in v6:
> > - New patch re-ordering fdt nodes and properties.
> > - Update commit message as requested by Wolfgang.
> > 
> > Changes in v5:
> > - Drop device tree part already done by Marek's patch.
> > - Add another fixes tag as his patch forgot the board code part.
> > - Re-based on top of u-boot-imx, master yet again.
> > 
> > Changes in v4:
> > - Add Heiko Schocher's reviewed-by tag.
> > - Fix copyright periods.
> > - Re-based.
> > 
> > Changes in v3:
> > - Case fold hex string.
> > - Revert binman part of imx8mm-verdin-u-boot.dtsi to a plain copy from
> >   imx8mm-evk and postpone further improvements to after migrating to a
> >   common binman config as agreed with Frieder and Simon.
> > - New patch cleaning up include order.
> > - Add Fabio's reviewed-by tag.
> > - Fix patch.
> > - Add missing apalis-imx8 part.
> > - While at it update copyright year resp. period.
> > - Fix closing endif comment.
> > 
> > Changes in v2:
> > - Explicitly pass filename to binman when generating binaries as
> >   suggested by Heiko.
> > - Use proper intermediate binary u-boot-spl-ddr.bin for imximage as
> >   pointed out by Heiko.
> > - Drop first patch ("imx: mkimage_fit_atf: fix legacy image generation")
> >   as a similar fix was already refused earlier.
> > - New patch allows booting recent embedded Linux BSPs.
> > - New patch addressing dynamic fdtfile definition.
> > - New patch fixing watchdog pinctrl issue.
> > 
> > Igor Opaniuk (1):
> >   verdin-imx8mm: use preboot for fdtfile evaluation
> > 
> > Marcel Ziswiler (7):
> >   imx8m: clean-up kconfig indentation
> >   verdin-imx8mm: fix ethernet
> >   ARM: dts: imx8mm-verdin: prepare for dek blob encapsulation
> >   arm64: dts: imx8mm-verdin-u-boot.dtsi: alphabetically re-order
> >   verdin-imx8mm: switch to use binman to pack images
> >   verdin-imx8mm: clean-up include order
> >   verdin-imx8mm: fix watchdog pinctrl issue
> > 
> > Max Krummenacher (2):
> >   verdin-imx8mm: enable sleep_moci output
> >   verdin-imx8mm: drop support for v1.0 hardware
> > 
> > Oleksandr Suvorov (1):
> >   include/configs: apalis-imx8/verdin-imx8mm: rename kernel image
> >     variable
> > 
> >  arch/arm/dts/imx8mm-verdin-u-boot.dtsi      | 147 +++++++++++++++++++-
> >  arch/arm/dts/imx8mm-verdin.dts              |  18 +++
> >  arch/arm/mach-imx/imx8m/Kconfig             |  21 +--
> >  board/toradex/verdin-imx8mm/imximage.cfg    |  11 +-
> >  board/toradex/verdin-imx8mm/verdin-imx8mm.c |  81 +----------
> >  configs/verdin-imx8mm_defconfig             |   6 +-
> >  doc/board/toradex/verdin-imx8mm.rst         |  53 ++++---
> >  include/configs/apalis-imx8.h               |   6 +-
> >  include/configs/verdin-imx8mm.h             |  10 +-
> >  9 files changed, 220 insertions(+), 133 deletions(-)
> > 
> > --
> > 2.26.2
> > 
> 
> Marcel,
> 
> I've tested your series with mx8mm-venice and did not see any issues.

Note that I have currently several patch series in-flight. I assume you meant this to go here [1] instead, not?

> Tested-by: Tim Harvey <tharvey@gateworks.com> for imx8mm-venice-* boards
> 
> Thanks, the common u-boot.dtsi is nice to see!

Thanks!

> I have a couple of patches that have not been picked up by Stefano yet
> due to I believe merge conflicts becuase his imx tree is behind master
> with respect to some of the Kconfig patches. You are likely in the
> same boat.

Yeah, however, with his pulls from Thursday evening imx/master is now based on commit ea67f467a43 ("Merge
branch '2021-10-06-assorted-improvements'") which is very close to todays origin/master. So I don't think there
should be any more conflicts if your stuff is re-based either on top of imx/master or origin/master.

> Stefano, is it best for me to rebase my 'imx8mm_venice: switch to use
> binman to pack images' and 'board: gateworks: venice: add
> imx8mn-gw7902 support' patches on your tree or are you going to be
> merging in origin/master soon?
> 
> Best regards,
> 
> Tim

[1] https://marc.info/?l=u-boot&m=163372696806292

Cheers

Marcel