From: Karel Zak <kzak@redhat.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: util-linux@vger.kernel.org, Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH] libuuid: Make the uuid_unparse functions inline
Date: Tue, 22 Jan 2019 13:04:01 +0100 [thread overview]
Message-ID: <20190122120401.4bppg5ikgi6svren@ws.net.home> (raw)
In-Reply-To: <20190121024510.GA22370@localhost>
On Sun, Jan 20, 2019 at 06:45:16PM -0800, Josh Triplett wrote:
> Various libraries, including libblkid, depend on libuuid solely to call
> uuid_unparse, which just prints a UUID.
It seems only libblkid requires solely uuid_unparse() :-) So, I guess
all we need is to use already implemented blkid_unparse_uuid() where
is the magic snprintf. I have applied this change:
https://github.com/karelzak/util-linux/commit/c2435b946f574880201cb41d989d8d63d4bbf87d
The another stuff (e.g. mkswap, libfdisk, ...) depends on uuid_parse()
or/and uuid_generate(). So, libuuid is required there.
> Move the uuid_unparse functions to uuid.h and make them static
> inline, so that applications depending solely on the uuid_unparse
> functions don't need to pull in libuuid. Keep the out-of-line
> symbols for compatibility with existing applications.
It seems unnecessary.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2019-01-22 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 2:45 [PATCH] libuuid: Make the uuid_unparse functions inline Josh Triplett
2019-01-22 12:04 ` Karel Zak [this message]
2019-01-22 18:55 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122120401.4bppg5ikgi6svren@ws.net.home \
--to=kzak@redhat.com \
--cc=arjan@linux.intel.com \
--cc=josh@joshtriplett.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).