From: bfields@fieldses.org (J. Bruce Fields)
To: Andrew W Elble <aweits@rit.edu>
Cc: Benjamin Coddington <bcodding@redhat.com>,
"J. Bruce Fields" <bfields@redhat.com>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
abe@purdue.edu, lsof-l@lists.purdue.edu,
util-linux@vger.kernel.org, jlayton@redhat.com
Subject: Re: [PATCH 09/10] nfsd: expose some more information about NFSv4 opens
Date: Mon, 6 May 2019 21:02:42 -0400 [thread overview]
Message-ID: <20190507010242.GB4835@fieldses.org> (raw)
In-Reply-To: <m2k1f8hmr5.fsf@discipline.rit.edu>
On Thu, May 02, 2019 at 11:58:06AM -0400, Andrew W Elble wrote:
> Benjamin Coddington <bcodding@redhat.com> writes:
>
> > On 25 Apr 2019, at 10:04, J. Bruce Fields wrote:
> >
> >> From: "J. Bruce Fields" <bfields@redhat.com>
> >>
> >> Add open modes, device numbers, inode numbers, and open owners to each
> >> line of nfsd/clients/#/opens.
> >>
> >> Open owners are totally opaque but seem to sometimes have some useful
> >> ascii strings included, so passing through printable ascii characters
> >> and escaping the rest seems useful while still being machine-readable.
> >> ---
> >> fs/nfsd/nfs4state.c | 40
> >> ++++++++++++++++++++++++++++------
> >> fs/nfsd/state.h | 2 +-
> >> fs/seq_file.c | 17 +++++++++++++++
> >> include/linux/seq_file.h | 2 ++
> >> include/linux/string_helpers.h | 1 +
> >> lib/string_helpers.c | 5 +++--
> >> 6 files changed, 57 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> >> index 829d1e5440d3..f53621a65e60 100644
> >> --- a/fs/nfsd/nfs4state.c
> >> +++ b/fs/nfsd/nfs4state.c
> >> @@ -42,6 +42,7 @@
> >> #include <linux/sunrpc/svcauth_gss.h>
> >> #include <linux/sunrpc/addr.h>
> >> #include <linux/jhash.h>
> >> +#include <linux/string_helpers.h>
> >> #include "xdr4.h"
> >> #include "xdr4cb.h"
> >> #include "vfs.h"
> >> @@ -2261,16 +2262,41 @@ static void opens_stop(struct seq_file *s,
> >> void *v)
> >> static int opens_show(struct seq_file *s, void *v)
> >> {
> >> struct nfs4_stid *st = v;
> >> - struct nfs4_ol_stateid *os;
> >> - u64 stateid;
> >> + struct nfs4_ol_stateid *ols;
> >> + struct nfs4_file *nf;
> >> + struct file *file;
> >> + struct inode *inode;
> >> + struct nfs4_stateowner *oo;
> >> + unsigned int access, deny;
> >>
> >> if (st->sc_type != NFS4_OPEN_STID)
> >> return 0; /* XXX: or SEQ_SKIP? */
> >> - os = openlockstateid(st);
> >> - /* XXX: get info about file, etc., here */
> >> + ols = openlockstateid(st);
> >> + oo = ols->st_stateowner;
> >> + nf = st->sc_file;
> >> + file = find_any_file(nf);
>
> Is there a matching fput() missing somewhere, or did I just not see it...?
Oops, fixed.
> >> + inode = d_inode(file->f_path.dentry);
> >> +
> >> + seq_printf(s, STATEID_FMT, STATEID_VAL(&st->sc_stateid));
> >
> > Should we match the byte order printed with what wireshark/tshark sees?
>
> ^^ +1
Yeah, I agree, I'm changing that to just be a "%16phN", which should
give us what wireshark does.
Thanks for the review!
--b.
next prev parent reply other threads:[~2019-05-07 1:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 14:04 [PATCH 00/10] exposing knfsd opens to userspace J. Bruce Fields
2019-04-25 14:04 ` [PATCH 01/10] nfsd: persist nfsd filesystem across mounts J. Bruce Fields
2019-04-25 14:04 ` [PATCH 02/10] nfsd: rename cl_refcount J. Bruce Fields
2019-04-25 14:04 ` [PATCH 03/10] nfsd4: use reference count to free client J. Bruce Fields
2019-04-25 14:04 ` [PATCH 04/10] nfsd: add nfsd/clients directory J. Bruce Fields
2019-04-25 14:04 ` [PATCH 05/10] nfsd: make client/ directory names small ints J. Bruce Fields
2019-04-25 14:04 ` [PATCH 06/10] rpc: replace rpc_filelist by tree_descr J. Bruce Fields
2019-04-25 14:04 ` [PATCH 07/10] nfsd4: add a client info file J. Bruce Fields
2019-04-25 14:04 ` [PATCH 08/10] nfsd4: add file to display list of client's opens J. Bruce Fields
2019-04-25 18:04 ` Jeff Layton
2019-04-25 20:14 ` J. Bruce Fields
2019-04-25 21:14 ` Andreas Dilger
2019-04-26 1:18 ` J. Bruce Fields
2019-05-16 0:40 ` J. Bruce Fields
2019-04-25 14:04 ` [PATCH 09/10] nfsd: expose some more information about NFSv4 opens J. Bruce Fields
2019-05-02 15:28 ` Benjamin Coddington
2019-05-02 15:58 ` Andrew W Elble
2019-05-07 1:02 ` J. Bruce Fields [this message]
2019-04-25 14:04 ` [PATCH 10/10] nfsd: add more information to client info file J. Bruce Fields
2019-04-25 17:02 ` [PATCH 00/10] exposing knfsd opens to userspace Jeff Layton
2019-04-25 20:01 ` J. Bruce Fields
2019-04-25 18:17 ` Jeff Layton
2019-04-25 21:08 ` Andreas Dilger
2019-04-25 23:20 ` NeilBrown
2019-04-26 11:00 ` Andreas Dilger
2019-04-26 12:56 ` J. Bruce Fields
2019-04-26 23:55 ` NeilBrown
2019-04-27 19:00 ` J. Bruce Fields
2019-04-28 22:57 ` NeilBrown
2019-04-27 0:03 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507010242.GB4835@fieldses.org \
--to=bfields@fieldses.org \
--cc=abe@purdue.edu \
--cc=aweits@rit.edu \
--cc=bcodding@redhat.com \
--cc=bfields@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lsof-l@lists.purdue.edu \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).