From: Karel Zak <kzak@redhat.com>
To: Yousong Zhou <yszhou4tech@gmail.com>
Cc: util-linux@vger.kernel.org, Yousong Zhou <zhouyousong@yunionyun.com>
Subject: Re: [PATCH] column: fix outputing empty column at the end of line
Date: Mon, 15 Jul 2019 10:00:18 +0200 [thread overview]
Message-ID: <20190715080018.tjfvon3vfpsp4uca@ws.net.home> (raw)
In-Reply-To: <CAECwjAhM1FmCoxZnxUxJcE+vCN5=uBd_SuMZEQ6qj8OKfCf3oA@mail.gmail.com>
On Sat, Jul 13, 2019 at 01:30:27PM +0800, Yousong Zhou wrote:
> On Thu, 27 Jun 2019 at 17:22, Yousong Zhou <yszhou4tech@gmail.com> wrote:
> >
> > The following commands manifests the problem. In old versions before
> > commit 4762ae9d60 ("column: use libsmartcols for --table"), both of them
> > should output with 2 "|"
> >
> > echo '||' | column -o '|' -s '|' -t
> > echo '|| ' | column -o '|' -s '|' -t
> >
> > Fixes: 4762ae9d60 ("column: use libsmartcols for --table")
> > Signed-off-by: Yousong Zhou <zhouyousong@yunionyun.com>
> > ---
>
> Hi, do you think this is a real bug and the fix a proper one? should
> I post a pull request through the github project page?
Sorry for delay, I had vacation last weekend.
I think your patch seems fine at first glance and send it to mailing
list is good enough. You do not have to use github PR. Thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2019-07-15 8:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 9:22 [PATCH] column: fix outputing empty column at the end of line Yousong Zhou
2019-07-13 5:30 ` Yousong Zhou
2019-07-15 8:00 ` Karel Zak [this message]
2019-07-27 8:43 ` Yousong Zhou
2019-07-27 18:49 ` Sami Kerola
2019-07-29 1:34 ` Yousong Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715080018.tjfvon3vfpsp4uca@ws.net.home \
--to=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
--cc=yszhou4tech@gmail.com \
--cc=zhouyousong@yunionyun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).