util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: zhenwei pi <pizhenwei@bytedance.com>
Cc: kerolasa@gmail.com, util-linux <util-linux@vger.kernel.org>
Subject: Re: [Phishing Risk] [External] irqtop todo note
Date: Mon, 6 Jan 2020 11:52:56 +0100	[thread overview]
Message-ID: <20200106105256.3phh5bdgs4qgqzpp@10.255.255.10> (raw)
In-Reply-To: <3e1bf9df-b530-738b-fc7f-00e4cf144420@bytedance.com>

On Sun, Jan 05, 2020 at 11:36:26AM +0800, zhenwei pi wrote:
> On 1/4/20 6:20 PM, Sami Kerola wrote:
> 
> > Hello,
> > 
> > I notice irqtop to todo file, so I decided to look into that. Changes
> > in my branch are nowhere near ready to be considered to upstream
> > ready, so no pull request yet maybe sometime later January or early
> > February. Meanwhile if someone else is working with the same I'm sure
> > efforts can be combined.
> > 
> > https://github.com/kerolasa/util-linux/commits/irqtop
> > 
> > Things to fix with my work.
> > 
> > * Save git history from https://github.com/pacepi/irqtop
> > * Write proper commit messages
> > * Use smartcolums
> > * Change output header to include hostname and iso timestamp
> > * Use signalfd to catch signals
> > * Use timerfd  for periodic execution
> > * Make main() shorter / simpler by moving bits and bobs to functions
> > * And the things I don't know yet, but without doubt there will be some
> > 
> Thanks for these works. Maybe it's ready to be merged into upstream.
> Hey, Karel, how do you think about this?

Later, for v2.35 is too late ;-)

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com


  parent reply	other threads:[~2020-01-06 10:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-04 10:20 irqtop todo note Sami Kerola
     [not found] ` <3e1bf9df-b530-738b-fc7f-00e4cf144420@bytedance.com>
2020-01-06 10:52   ` Karel Zak [this message]
2020-02-06  1:20     ` [Phishing Risk] [External] " zhenwei pi
2020-02-08 17:25       ` Sami Kerola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200106105256.3phh5bdgs4qgqzpp@10.255.255.10 \
    --to=kzak@redhat.com \
    --cc=kerolasa@gmail.com \
    --cc=pizhenwei@bytedance.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).