From: Karel Zak <kzak@redhat.com>
To: "Aurélien Lajoie" <orel@melix.net>
Cc: util-linux@vger.kernel.org
Subject: Re: cal: column mode
Date: Tue, 14 Apr 2020 13:38:27 +0200 [thread overview]
Message-ID: <20200414113827.xp2etrdev2oom4qc@ws.net.home> (raw)
In-Reply-To: <CAA0A08U=eWWB5eyxg4vrD_yBdVohqVT0NQfm+DG+wjbZ8HmiZg@mail.gmail.com>
On Mon, Apr 13, 2020 at 10:41:34PM +0200, Aurélien Lajoie wrote:
> As I have announced few days ago, I have started to work on ncal like for cal.
> I have push a first working version on my github:
> https://github.com/utix/util-linux/commits/cal_column
Is the option --column the best name? We use "column" pretty often to
address output in columns or number of columns, etc.
What about --vertical?
> I will now add some tests, and improve my code.
Cool.
> Does anyone know which locale can have some width issue ?
LC_ALL=ja_JP.utf8 cal
or another with multibyte letters.
> I have tried to keep the same structure of the code between the column
> mode and the row mode.
> It is impossible to keep line width lower than 80.
Do you mean source code line? ... 80 is not a strict rule, keep it
readable.
> I can try to split the big function `cal_output_months` this will make
> it more readable, but will introduce a lot of change for no feature.
> Any advice on this ?
Your cal_col_output_months() does not look like any huge monster.
I have added one comment to your commits/cal_column at github.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2020-04-14 11:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 20:41 cal: column mode Aurélien Lajoie
2020-04-14 11:38 ` Karel Zak [this message]
2020-04-14 20:18 ` Aurélien Lajoie
2020-04-15 22:04 ` Bruce Dubbs
2020-05-06 13:35 ` Karel Zak
2020-05-06 19:06 ` Aurélien Lajoie
2020-05-06 21:13 ` Aurélien Lajoie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414113827.xp2etrdev2oom4qc@ws.net.home \
--to=kzak@redhat.com \
--cc=orel@melix.net \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).