From: Karel Zak <kzak@redhat.com>
To: J William Piggott <elseifthen@gmx.com>, util-linux@vger.kernel.org
Subject: Re: settimeofday() portability in hwclock
Date: Fri, 22 May 2020 11:53:08 +0200 [thread overview]
Message-ID: <20200522095308.tqgp37hen2zvcj3r@ws.net.home> (raw)
In-Reply-To: <20200511121954.pi5wpbwxqtli7gha@ws.net.home>
On Mon, May 11, 2020 at 02:19:58PM +0200, Karel Zak wrote:
> please, review this patch. It seems we need to somehow hide libc
> maintainers' creativity as settimeofday() have different behavior on
> different libcs ;-) For example musl-C completely ignores TZ.
>
> I'd like to keep the current structure of our code (IMHO it's pretty
> readable now), so I have introduced __set_time() and __set_timezone()
> to hide the portability issues.
Applied.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2020-05-22 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 12:19 settimeofday() portability in hwclock Karel Zak
2020-05-22 9:53 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522095308.tqgp37hen2zvcj3r@ws.net.home \
--to=kzak@redhat.com \
--cc=elseifthen@gmx.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).