Re: [PATCH v2 2/5] Add uclampset schedutil

[Qais Yousef <qais.yousef@arm.com>]

On 02/02/21 09:01, Karel Zak wrote:
> On Mon, Feb 01, 2021 at 05:32:02PM +0000, Qais Yousef wrote:
> > On 02/01/21 17:12, Karel Zak wrote:
> > > On Sat, Jan 30, 2021 at 08:50:36PM +0000, Qais Yousef wrote:
> > > 
> > > Now I see that you have reused chrt concept of --pid. We keep it for
> > > chrt due to backward compatibility, but for new util it would be
> > > better to use standard 'required_argument' for --pid.
> > 
> > Hmm what does required mean here? --pid is optional. But if passed, a value
> > is required to be passed indeed.
> 
> It means a value required if --pid specified.
> 
> > > > +	static const struct option longopts[] = {
> > > > +		{ "all-tasks",		no_argument, NULL, 'a' },
> > > > +		{ "pid",		no_argument, NULL, 'p' },
> > > 
> > >  { "pid", required_argument, NULL, 'p' },
> > 
> > Assuming this means --pid must be followed by a value then indeed that's what
> > we expect to happen.
> 
>  Yes.
> 
> > will fix this and the 2 other occurrences below to include in v3.
> 
> You don't have to send it to the mailing list, juts update your
> github repo and I'll merge it :-) Thanks.

Thanks a lot Karel. Pushed a new uclampset-v3 branch so that you can easily
review the diff against v2 before merging.

Cheers

--
Qais Yousef