From: Sami Kerola <kerolasa@iki.fi>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH 0/2] more(1) use libmagic and make page up/down and arrow keys work
Date: Tue, 12 May 2020 14:45:36 +0100 [thread overview]
Message-ID: <CAG27Bk0_upB1-tVotyFM-fs2vt_JEYpXV6-H714YV5z-aB1DDA@mail.gmail.com> (raw)
In-Reply-To: <20200512085358.yjfl7ryg4bq3tpx4@ws.net.home>
On Tue, 12 May 2020 at 09:54, Karel Zak <kzak@redhat.com> wrote:
> On Wed, May 06, 2020 at 08:19:21PM +0100, Sami Kerola wrote:
> > Here are two changes to more(1) that where requested in earlier github
> > pull[1] request to get review in maillist, so here we go.
>
> Applied, thanks.
>
> > First one of the changes will link more(1) with libmagic so that various
> > binary formats can be detected with effect the pager will not mess up
> > termial.
>
> It seems we do not have devel package for libmagic in Fedora.
Oh, that's a little disappointing. Archlinux has libmagic in core
repository and that lead me thinking it is quite likely part of even
most minimal installation, but apparently I was wrong.
> > Second change is perhaps a little bit more exciting. It will add page-up,
> > page-down, arrow-up, and arrow-down movements to more(1). This pager has
> > known now to scroll back and forth since long time ago, but most of the
> > people do not seem to know key bindings so lets help users by assigning the
> > most obvious buttons the way one might expect them to work.
>
> This is nice feature, maybe also add arrow keys to move one line
> up/down.
Funny you said that. The more(1) movements are still quite disappointing
when trying to read the code. Sometime before Christmas I will try to
address that along with adding posix required more(1) key-bindings.
But there is no hope these would be ready before next util-linux release
so now we have a little unexpected movements for a bit. I hope that
is still an improvement to earlier situation when going backwards
seemed to be impossible for most of the users.
Thank you for review and merge Karel.
--
Sami Kerola
http://www.iki.fi/kerolasa/
prev parent reply other threads:[~2020-05-12 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 19:19 [PATCH 0/2] more(1) use libmagic and make page up/down and arrow keys work Sami Kerola
2020-05-06 19:19 ` [PATCH 1/2] more: use libmagic to identify binary files Sami Kerola
2020-05-06 19:19 ` [PATCH 2/2] more: make page and arrow up/down to update view Sami Kerola
2020-05-12 8:53 ` [PATCH 0/2] more(1) use libmagic and make page up/down and arrow keys work Karel Zak
2020-05-12 13:45 ` Sami Kerola [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG27Bk0_upB1-tVotyFM-fs2vt_JEYpXV6-H714YV5z-aB1DDA@mail.gmail.com \
--to=kerolasa@iki.fi \
--cc=kerolasa@gmail.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).