From: Vincent Guittot <vincent.guittot@linaro.org>
To: Qais Yousef <qais.yousef@arm.com>
Cc: util-linux@vger.kernel.org,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Patrick Bellasi <patrick.bellasi@matbug.net>
Subject: Re: [PATCH 3/5] uclampset: Add man page
Date: Mon, 25 Jan 2021 09:26:13 +0100 [thread overview]
Message-ID: <CAKfTPtDwe98LmnyN8uU28fsekVQF=RBtTqm+gcpr0SJeTwr61g@mail.gmail.com> (raw)
In-Reply-To: <20210123183133.dniog4z2rxw45sd6@e107158-lin>
On Sat, 23 Jan 2021 at 19:31, Qais Yousef <qais.yousef@arm.com> wrote:
>
> On 01/20/21 15:46, Vincent Guittot wrote:
> > > +.TP
> > > +For example:
> > > +.B uclampset \-s
> > > +.I -m\ 512
> > > +.I -M\ 700
> > > +.PP
> > > +will prevent any task from being boosted higher than 512. And all tasks in the
> >
> > will prevent any task from being boosted higher than 700
>
> 700 or 512 you mean here?
>
> > or
> > will ensure any task to be boosted higher than 512
>
> It is certainly not that. That's the confusion I was trying to clear up in this
> note. The system values are _constraints_. It sets an upper bound on the
> maximum uclamp_min/max value the system will apply.
>
> For example if a task::uclamp_min=1024 but the system::uclamp_min=512 512, then
> effectively the task will only be boosted to 512. Once this restriction is left
> by setting system::uclamp_min=1024 again, then the task will get the boost
> value it requested.
ok, I got confused because uclamp -p PID -min 512 - M 700 and uclamp
-s -min 512 - M 700 look quite similar but their behaviors are quite
different.
I mean
uclamp -p PID -min 512 - M 700 will ensure that the task's utilization
will be always reported in the range [512:700]
The behavior is the same for the cgroup with cpu.uclamp.min and cpu.uclamp.max
whereas
uclamp -s -min 512 - M 700 will do the opposite; i.e. the min of
task's utilization range will never be above 512
TBH I don't know how to make it clear that the behavior of -min is the
opposite between -p and -s
>
> I'm open to suggestions on how to better explain this..
>
> Thanks
>
> --
> Qais Yousef
next prev parent reply other threads:[~2021-01-26 6:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 19:09 [PATCH 0/5] Add a new uclampset utility Qais Yousef
2021-01-16 19:09 ` [PATCH 1/5] Move sched_attr struct and syscall definitions into header file Qais Yousef
2021-01-20 10:25 ` Karel Zak
2021-01-23 16:50 ` Qais Yousef
2021-01-16 19:09 ` [PATCH 2/5] Add uclampset schedutil Qais Yousef
2021-01-20 12:21 ` Karel Zak
2021-01-23 18:26 ` Qais Yousef
2021-01-16 19:09 ` [PATCH 3/5] uclampset: Add man page Qais Yousef
2021-01-20 12:22 ` Karel Zak
2021-01-23 18:36 ` Qais Yousef
2021-01-20 14:46 ` Vincent Guittot
2021-01-23 18:31 ` Qais Yousef
2021-01-25 8:26 ` Vincent Guittot [this message]
2021-01-26 15:08 ` Qais Yousef
2021-01-16 19:09 ` [PATCH 4/5] uclampset: Plump into the build system Qais Yousef
2021-01-16 19:09 ` [PATCH 5/5] uclampset: Plumb in bash-completion Qais Yousef
2021-01-18 13:06 ` [PATCH 0/5] Add a new uclampset utility Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKfTPtDwe98LmnyN8uU28fsekVQF=RBtTqm+gcpr0SJeTwr61g@mail.gmail.com' \
--to=vincent.guittot@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).