From: Stanislav Brabec <sbrabec@suse.cz>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 3/3] agetty: Reload only if it is really needed
Date: Thu, 11 Oct 2018 21:37:07 +0200 [thread overview]
Message-ID: <ac83a915-5a73-c4ff-6d43-2fea33166754@suse.cz> (raw)
In-Reply-To: <20181011122337.gecalp2lyf725ah3@ws.net.home>
Karel Zak wrote:
> Can you retest the current master branch with my changes? I do not
> expect any issue, but for sure...
Works as expected.
There is one remaining issue:
Reload happens even if user already started to type logname. It is very
uncomfortable, and it can even lead to problems with login. I tried to
fix that: Once any letter is already entered, reload will be blocked
and postponed.
To fix this, we would need to disable reloads once any character was
entered. It would require switch to character mode and custom handling
of backspace. I am not sure, whether we want this.
--
Best Regards / S pozdravem,
Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o. e-mail: sbrabec@suse.com
Křižíkova 148/34 (Corso IIa) tel: +49 911 7405384547
186 00 Praha 8-Karlín fax: +420 284 084 001
Czech Republic http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76
next prev parent reply other threads:[~2018-10-11 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 17:26 [PATCH 3/3] agetty: Reload only if it is really needed Stanislav Brabec
2018-10-11 12:23 ` Karel Zak
2018-10-11 19:37 ` Stanislav Brabec [this message]
2018-10-12 8:36 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac83a915-5a73-c4ff-6d43-2fea33166754@suse.cz \
--to=sbrabec@suse.cz \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).