From: Halil Pasic <pasic@linux.ibm.com>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: virtio-dev@lists.oasis-open.org,
virtio-comment@lists.oasis-open.org,
Cornelia Huck <cohuck@redhat.com>,
Parav Pandit <parav@nvidia.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Alvaro Karsz <alvaro.karsz@solid-run.com>,
David Edmondson <david.edmondson@oracle.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation
Date: Tue, 4 Apr 2023 18:29:25 +0200 [thread overview]
Message-ID: <20230404182925.349d402e.pasic@linux.ibm.com> (raw)
In-Reply-To: <20230323152422.113103-1-hengqi@linux.alibaba.com>
On Thu, 23 Mar 2023 23:24:22 +0800
Heng Qi <hengqi@linux.alibaba.com> wrote:
> +struct virtio_net_ctrl_coal_vq {
> + le16 vqn;
> + le16 reserved;
> + struct virtio_net_ctrl_coal coal;
> +};
> +
> #define VIRTIO_NET_CTRL_NOTF_COAL 6
> #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET 0
> #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1
> + #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET 2
> + #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET 3
> \end{lstlisting}
>
> Coalescing parameters:
> \begin{itemize}
> +\item \field{vqn}: The virtqueue number of an enabled transmit or receive virtqueue.
Just to be on the safe side: VIRTIO_F_NOTIF_CONFIG_DATA has been
negotiated, and queue_select != queue_notify_data, is vqn supposed
to contain queue_notify_data or the number/index that is used for
queue_select (I'm talking about the PCI transport case)?
Regards,
Halil
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-04-04 16:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 15:24 [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation Heng Qi
2023-03-23 15:38 ` Heng Qi
2023-04-11 8:05 ` Cornelia Huck
2023-04-11 8:42 ` Heng Qi
2023-04-11 10:32 ` Michael S. Tsirkin
2023-04-11 10:51 ` Cornelia Huck
2023-04-04 16:29 ` Halil Pasic [this message]
2023-04-04 16:32 ` Parav Pandit
2023-04-04 17:44 ` Michael S. Tsirkin
2023-04-04 19:39 ` Parav Pandit
2023-04-04 20:14 ` Michael S. Tsirkin
2023-04-04 20:50 ` Parav Pandit
2023-04-05 9:12 ` Michael S. Tsirkin
2023-04-05 14:54 ` Halil Pasic
2023-04-11 10:37 ` Michael S. Tsirkin
2023-04-07 11:45 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-10 13:33 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404182925.349d402e.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=alvaro.karsz@solid-run.com \
--cc=cohuck@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).