From: Harald Mommer <harald.mommer@opensynergy.com>
To: Haixu Cui <quic_haixcui@quicinc.com>
Cc: quic_ztu@quicinc.com, Matti Moell <Matti.Moell@opensynergy.com>,
Mikhail Golubev <Mikhail.Golubev@opensynergy.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
Mark Brown <broonie@kernel.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>
Subject: Re: [virtio-dev] Re: [RFC PATCH v3 3/3] SPI: Add virtio SPI driver.
Date: Mon, 4 Mar 2024 11:52:28 +0100 [thread overview]
Message-ID: <2a911f96-eed9-4adc-9043-27fd1d3a7ca2@opensynergy.com> (raw)
In-Reply-To: <e2e5a7a0-7a2b-40d3-acf7-6f0b91bd5d40@quicinc.com>
Hello Haixu,
no, I've not touched spidev.c. Nowhere. I took Vanilla next/stable and
applied the patches I sent.
Run the driver as a (somewhat different but comparable) module on 6.5 on
hardware over virtio-MMIO. Probes and goes live.
Tested on next/stable using a specially adapted QEMU version which
allows the usage of our proprietary virtio SPI device over PCI in qemu.
Probes and goes live.
There may be other patches in the setup we're using I'm not aware of but
not this one.
Only in case you're using some locally developed virtio SPI device on
qemu which uses PCI transport:
SPI has ID 45. Means 0x2d.
https://www.qemu.org/docs/master/specs/pci-ids.html
1af4:1040 to 1af4:10ef
ID range for modern virtio devices. The PCI device ID is calculated
from the virtio device ID by adding the 0x1040 offset. ...
lspci on qemu:
/ # lspci
...
00:03.0 Class 00ff: 1af4:106d
...
/ #
You see something like this?
Regards
Harald
On 04.03.24 08:11, Haixu Cui wrote:
>
>
> On 2/13/2024 9:53 PM, Harald Mommer wrote:
>> +static struct spi_board_info board_info = {
>> + .modalias = "spi-virtio",
>> +};
>
> Hi Harald,
> Do you add "spi-virtio" in spidev_spi_ids in spidev.c when you
> doing the tests, to probe spidev driver?
>
> Thanks
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2024-03-04 10:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 13:53 [virtio-dev] [RFC PATCH v3 0/3] Virtio SPI Linux driver compliant to draft spec V10 Harald Mommer
2024-02-13 13:53 ` [virtio-dev] [RFC PATCH v3 1/3] virtio: Add ID for virtio SPI Harald Mommer
2024-02-13 13:53 ` [virtio-dev] [RFC PATCH v3 2/3] virtio-spi: Add virtio-spi.h Harald Mommer
2024-02-13 13:53 ` [virtio-dev] [RFC PATCH v3 3/3] SPI: Add virtio SPI driver Harald Mommer
2024-02-20 8:30 ` [virtio-dev] " Haixu Cui
2024-02-26 10:41 ` Harald Mommer
[not found] ` <3b8e947c-51fb-461e-bb9e-7bc1bb547471@sirena.org.uk>
2024-02-27 14:12 ` Harald Mommer
2024-03-04 7:11 ` Haixu Cui
2024-03-04 10:52 ` Harald Mommer [this message]
2024-02-14 16:22 ` [virtio-dev] [RFC PATCH v3 0/3] Virtio SPI Linux driver compliant to draft spec V10 Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a911f96-eed9-4adc-9043-27fd1d3a7ca2@opensynergy.com \
--to=harald.mommer@opensynergy.com \
--cc=Matti.Moell@opensynergy.com \
--cc=Mikhail.Golubev@opensynergy.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=quic_haixcui@quicinc.com \
--cc=quic_ztu@quicinc.com \
--cc=viresh.kumar@linaro.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).