Re: [PATCH net-next 2/3] virtio_net: fix possible dim status unrecoverable

From: Jakub Kicinski <kuba@kernel.org>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	Eric Dumazet <edumazet@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 2/3] virtio_net: fix possible dim status unrecoverable
Date: Thu, 25 Apr 2024 19:21:50 -0700	[thread overview]
Message-ID: <20240425192150.0685d4b3@kernel.org> (raw)
In-Reply-To: <20240425125855.87025-3-hengqi@linux.alibaba.com>

On Thu, 25 Apr 2024 20:58:54 +0800 Heng Qi wrote:
> When the dim worker is scheduled, if it no longer needs to issue
> commands, dim may not be able to return to the working state later.
> 
> For example, the following single queue scenario:
>   1. The dim worker of rxq0 is scheduled, and the dim status is
>      changed to DIM_APPLY_NEW_PROFILE;
>   2. dim is disabled or parameters have not been modified;
>   3. virtnet_rx_dim_work exits directly;
> 
> Then, even if net_dim is invoked again, it cannot work because the
> state is not restored to DIM_START_MEASURE.
> 
> Fixes: 6208799553a8 ("virtio-net: support rx netdim")
> Signed-off-by: Heng Qi <hengqi@linux.alibaba.com>

This sounds like a legitimate bug fix so it needs to be sent separately
to the net tree (subject tagged with [PATCH net]) and then you'll have
to wait until the following Thursday for the net tree to get merged
into net-next. At which point you can send the improvements.
(Without the wait there would be a conflict between the trees).

Right now the series does not apply to net-next anyway.
-- 
pw-bot: cr