From: Jason Wang <jasowang@redhat.com>
To: Xie Yongji <xieyongji@bytedance.com>,
mst@redhat.com, stefanha@redhat.com, sgarzare@redhat.com,
parav@nvidia.com, akpm@linux-foundation.org,
rdunlap@infradead.org, willy@infradead.org,
viro@zeniv.linux.org.uk, axboe@kernel.dk, bcrl@kvack.org,
corbet@lwn.net
Cc: linux-aio@kvack.org, kvm@vger.kernel.org, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC v2 08/13] vdpa: Introduce process_iotlb_msg() in vdpa_config_ops
Date: Wed, 23 Dec 2020 16:36:47 +0800 [thread overview]
Message-ID: <5b36bc51-1e19-2b59-6287-66aed435c8ed@redhat.com> (raw)
In-Reply-To: <20201222145221.711-9-xieyongji@bytedance.com>
On 2020/12/22 下午10:52, Xie Yongji wrote:
> This patch introduces a new method in the vdpa_config_ops to
> support processing the raw vhost memory mapping message in the
> vDPA device driver.
>
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
> ---
> drivers/vhost/vdpa.c | 5 ++++-
> include/linux/vdpa.h | 7 +++++++
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index 448be7875b6d..ccbb391e38be 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -728,6 +728,9 @@ static int vhost_vdpa_process_iotlb_msg(struct vhost_dev *dev,
> if (r)
> return r;
>
> + if (ops->process_iotlb_msg)
> + return ops->process_iotlb_msg(vdpa, msg);
> +
> switch (msg->type) {
> case VHOST_IOTLB_UPDATE:
> r = vhost_vdpa_process_iotlb_update(v, msg);
> @@ -770,7 +773,7 @@ static int vhost_vdpa_alloc_domain(struct vhost_vdpa *v)
> int ret;
>
> /* Device want to do DMA by itself */
> - if (ops->set_map || ops->dma_map)
> + if (ops->set_map || ops->dma_map || ops->process_iotlb_msg)
> return 0;
>
> bus = dma_dev->bus;
> diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
> index 656fe264234e..7bccedf22f4b 100644
> --- a/include/linux/vdpa.h
> +++ b/include/linux/vdpa.h
> @@ -5,6 +5,7 @@
> #include <linux/kernel.h>
> #include <linux/device.h>
> #include <linux/interrupt.h>
> +#include <linux/vhost_types.h>
> #include <linux/vhost_iotlb.h>
> #include <net/genetlink.h>
>
> @@ -172,6 +173,10 @@ struct vdpa_iova_range {
> * @vdev: vdpa device
> * Returns the iova range supported by
> * the device.
> + * @process_iotlb_msg: Process vhost memory mapping message (optional)
> + * Only used for VDUSE device now
> + * @vdev: vdpa device
> + * @msg: vhost memory mapping message
> * @set_map: Set device memory mapping (optional)
> * Needed for device that using device
> * specific DMA translation (on-chip IOMMU)
> @@ -240,6 +245,8 @@ struct vdpa_config_ops {
> struct vdpa_iova_range (*get_iova_range)(struct vdpa_device *vdev);
>
> /* DMA ops */
> + int (*process_iotlb_msg)(struct vdpa_device *vdev,
> + struct vhost_iotlb_msg *msg);
> int (*set_map)(struct vdpa_device *vdev, struct vhost_iotlb *iotlb);
> int (*dma_map)(struct vdpa_device *vdev, u64 iova, u64 size,
> u64 pa, u32 perm);
Is there any reason that it can't be done via dma_map/dma_unmap or set_map?
Thanks
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-12-23 8:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201222145221.711-1-xieyongji@bytedance.com>
[not found] ` <20201222145221.711-2-xieyongji@bytedance.com>
2020-12-22 15:44 ` [RFC v2 01/13] mm: export zap_page_range() for driver use Christoph Hellwig
2020-12-23 6:38 ` [RFC v2 00/13] Introduce VDUSE - vDPA Device in Userspace Jason Wang
2020-12-23 8:14 ` Jason Wang
[not found] ` <CACycT3tr-1EDeH4j0AojD+-qM5yqDUU0tQHieVUXgL7AOTHyvQ@mail.gmail.com>
2020-12-24 2:24 ` Jason Wang
[not found] ` <20201222145221.711-7-xieyongji@bytedance.com>
2020-12-23 8:08 ` [RFC v2 06/13] vduse: " Jason Wang
[not found] ` <CACycT3vYb_CdWz3wZ1OY=KynG=1qZgaa_Ngko2AO0JHn_fFXEA@mail.gmail.com>
2020-12-24 3:01 ` Jason Wang
[not found] ` <CACycT3uKb1P7zXyCBYWDb6VhGXV0cdJPH3CPcRzjwz57tyODgA@mail.gmail.com>
2020-12-25 6:59 ` Jason Wang
2021-01-08 13:32 ` Bob Liu
[not found] ` <20201222145221.711-9-xieyongji@bytedance.com>
2020-12-23 8:36 ` Jason Wang [this message]
[not found] ` <CACycT3tP8mgj043idjJW3BF12qmOhmHzYz8X5FyL8t5MbwLysw@mail.gmail.com>
2020-12-24 2:36 ` [RFC v2 08/13] vdpa: Introduce process_iotlb_msg() in vdpa_config_ops Jason Wang
[not found] ` <20201222145221.711-10-xieyongji@bytedance.com>
2020-12-23 9:05 ` [RFC v2 09/13] vduse: Add support for processing vhost iotlb message Jason Wang
[not found] ` <CACycT3vVU9vg6R6UujSnSdk8cwxWPVgeJJs0JaBH_Zg4xC-epQ@mail.gmail.com>
2020-12-24 2:41 ` [External] " Jason Wang
[not found] ` <CACycT3s=m=PQb5WFoMGhz8TNGme4+=rmbbBTtrugF9ZmNnWxEw@mail.gmail.com>
2020-12-25 6:57 ` Jason Wang
[not found] ` <CACycT3uwXBYvRbKDWdN3oCekv+o6_Lc=-KTrxejD=fr-zgibGw@mail.gmail.com>
2020-12-28 7:43 ` Jason Wang
[not found] ` <CACycT3uDV43ecScrMh1QVpStuwDETHykJzzY=pkmZjP2Dd2kvg@mail.gmail.com>
2020-12-28 8:43 ` Jason Wang
[not found] ` <CACycT3soQoX5avZiFBLEGBuJpdni6-UxdhAPGpWHBWVf+dEySg@mail.gmail.com>
2020-12-29 9:11 ` Jason Wang
[not found] ` <CACycT3sg61yRdupnD+jQEkWKsVEvMWfhkJ=5z_bYZLxCibDiHw@mail.gmail.com>
2020-12-30 6:10 ` Jason Wang
[not found] ` <CACycT3vZ7V5WWhCFLBK6FuvVNmPmMj_yc=COOB4cjjC13yHUwg@mail.gmail.com>
2020-12-30 8:41 ` Jason Wang
[not found] ` <CACycT3tD3zyvV6Zy5NT4x=02hBgrRGq35xeTsRXXx-_wPGJXpQ@mail.gmail.com>
2020-12-31 2:49 ` Jason Wang
[not found] ` <CACycT3vwMU5R7N8dZFBYX4-bxe2YT7EfK_M_jEkH8wzfH_GkBw@mail.gmail.com>
2020-12-31 5:49 ` Jason Wang
[not found] ` <CACycT3tc2P63k6J9ZkWTpPvHk_H8zUq0_Q6WOqYX_dSigUAnzA@mail.gmail.com>
2020-12-31 7:11 ` Jason Wang
[not found] ` <CACycT3tLG=13fDdY0YPzViK2-AUy5F+uJor2cmVDFOGjXTOaYA@mail.gmail.com>
2020-12-25 7:02 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b36bc51-1e19-2b59-6287-66aed435c8ed@redhat.com \
--to=jasowang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=corbet@lwn.net \
--cc=kvm@vger.kernel.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=rdunlap@infradead.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).