From: Auger Eric <eric.auger@redhat.com>
To: Vivek Gautam <vivek.gautam@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org,
virtualization@lists.linux-foundation.org
Cc: jean-philippe@linaro.org, jacob.jun.pan@linux.intel.com,
mst@redhat.com, joro@8bytes.org, will.deacon@arm.com,
shameerali.kolothum.thodi@huawei.com, yi.l.liu@intel.com,
lorenzo.pieralisi@arm.com, robin.murphy@arm.com
Subject: Re: [PATCH RFC v1 00/15] iommu/virtio: Nested stage support with Arm
Date: Tue, 19 Jan 2021 10:03:22 +0100 [thread overview]
Message-ID: <a8fd0176-3888-44cf-d659-2e2213a59969@redhat.com> (raw)
In-Reply-To: <20210115121342.15093-1-vivek.gautam@arm.com>
Hi Vivek,
On 1/15/21 1:13 PM, Vivek Gautam wrote:
> This patch-series aims at enabling Nested stage translation in guests
> using virtio-iommu as the paravirtualized iommu. The backend is supported
> with Arm SMMU-v3 that provides nested stage-1 and stage-2 translation.
>
> This series derives its purpose from various efforts happening to add
> support for Shared Virtual Addressing (SVA) in host and guest. On Arm,
> most of the support for SVA has already landed. The support for nested
> stage translation and fault reporting to guest has been proposed [1].
> The related changes required in VFIO [2] framework have also been put
> forward.
>
> This series proposes changes in virtio-iommu to program PASID tables
> and related stage-1 page tables. A simple iommu-pasid-table library
> is added for this purpose that interacts with vendor drivers to
> allocate and populate PASID tables.
> In Arm SMMUv3 we propose to pull the Context Descriptor (CD) management
> code out of the arm-smmu-v3 driver and add that as a glue vendor layer
> to support allocating CD tables, and populating them with right values.
> These CD tables are essentially the PASID tables and contain stage-1
> page table configurations too.
> A request to setup these CD tables come from virtio-iommu driver using
> the iommu-pasid-table library when running on Arm. The virtio-iommu
> then pass these PASID tables to the host using the right virtio backend
> and support in VMM.
>
> For testing we have added necessary support in kvmtool. The changes in
> kvmtool are based on virtio-iommu development branch by Jean-Philippe
> Brucker [3].
>
> The tested kernel branch contains following in the order bottom to top
> on the git hash -
> a) v5.11-rc3
> b) arm-smmu-v3 [1] and vfio [2] changes from Eric to add nested page
> table support for Arm.
> c) Smmu test engine patches from Jean-Philippe's branch [4]
> d) This series
> e) Domain nesting info patches [5][6][7].
> f) Changes to add arm-smmu-v3 specific nesting info (to be sent to
> the list).
>
> This kernel is tested on Neoverse reference software stack with
> Fixed virtual platform. Public version of the software stack and
> FVP is available here[8][9].
>
> A big thanks to Jean-Philippe for his contributions towards this work
> and for his valuable guidance.
>
> [1] https://lore.kernel.org/linux-iommu/20201118112151.25412-1-eric.auger@redhat.com/T/
> [2] https://lore.kernel.org/kvmarm/20201116110030.32335-12-eric.auger@redhat.com/T/
> [3] https://jpbrucker.net/git/kvmtool/log/?h=virtio-iommu/devel
> [4] https://jpbrucker.net/git/linux/log/?h=sva/smmute
> [5] https://lore.kernel.org/kvm/1599734733-6431-2-git-send-email-yi.l.liu@intel.com/
> [6] https://lore.kernel.org/kvm/1599734733-6431-3-git-send-email-yi.l.liu@intel.com/
> [7] https://lore.kernel.org/kvm/1599734733-6431-4-git-send-email-yi.l.liu@intel.com/
> [8] https://developer.arm.com/tools-and-software/open-source-software/arm-platforms-software/arm-ecosystem-fvps
> [9] https://git.linaro.org/landing-teams/working/arm/arm-reference-platforms.git/about/docs/rdn1edge/user-guide.rst
Could you share a public branch where we could find all the kernel pieces.
Thank you in advance
Best Regards
Eric
>
> Jean-Philippe Brucker (6):
> iommu/virtio: Add headers for table format probing
> iommu/virtio: Add table format probing
> iommu/virtio: Add headers for binding pasid table in iommu
> iommu/virtio: Add support for INVALIDATE request
> iommu/virtio: Attach Arm PASID tables when available
> iommu/virtio: Add support for Arm LPAE page table format
>
> Vivek Gautam (9):
> iommu/arm-smmu-v3: Create a Context Descriptor library
> iommu: Add a simple PASID table library
> iommu/arm-smmu-v3: Update drivers to work with iommu-pasid-table
> iommu/arm-smmu-v3: Update CD base address info for user-space
> iommu/arm-smmu-v3: Set sync op from consumer driver of cd-lib
> iommu: Add asid_bits to arm smmu-v3 stage1 table info
> iommu/virtio: Update table format probing header
> iommu/virtio: Prepare to add attach pasid table infrastructure
> iommu/virtio: Update fault type and reason info for viommu fault
>
> drivers/iommu/arm/arm-smmu-v3/Makefile | 2 +-
> .../arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c | 283 +++++++
> .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 16 +-
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 268 +------
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 4 +-
> drivers/iommu/iommu-pasid-table.h | 140 ++++
> drivers/iommu/virtio-iommu.c | 692 +++++++++++++++++-
> include/uapi/linux/iommu.h | 2 +-
> include/uapi/linux/virtio_iommu.h | 158 +++-
> 9 files changed, 1303 insertions(+), 262 deletions(-)
> create mode 100644 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c
> create mode 100644 drivers/iommu/iommu-pasid-table.h
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2021-01-19 9:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210115121342.15093-1-vivek.gautam@arm.com>
2021-01-19 9:03 ` Auger Eric [this message]
[not found] ` <ba4c30b9-1f31-f6b2-e69a-7bb71ce74d57@arm.com>
2021-01-25 8:43 ` [PATCH RFC v1 00/15] iommu/virtio: Nested stage support with Arm Auger Eric
[not found] ` <20210115121342.15093-3-vivek.gautam@arm.com>
2021-03-03 17:11 ` [PATCH RFC v1 02/15] iommu: Add a simple PASID table library Jean-Philippe Brucker
[not found] ` <cd030006-2701-206d-5fca-e0e7afff316a@arm.com>
2021-03-29 16:25 ` Jean-Philippe Brucker
[not found] ` <20210115121342.15093-5-vivek.gautam@arm.com>
2021-03-03 17:14 ` [PATCH RFC v1 04/15] iommu/arm-smmu-v3: Update CD base address info for user-space Jean-Philippe Brucker
[not found] ` <20210115121342.15093-6-vivek.gautam@arm.com>
2021-03-03 17:15 ` [PATCH RFC v1 05/15] iommu/arm-smmu-v3: Set sync op from consumer driver of cd-lib Jean-Philippe Brucker
[not found] ` <20210115121342.15093-7-vivek.gautam@arm.com>
2021-03-03 17:17 ` [PATCH RFC v1 06/15] iommu/virtio: Add headers for table format probing Jean-Philippe Brucker
[not found] ` <20210115121342.15093-9-vivek.gautam@arm.com>
2021-03-03 17:18 ` [PATCH RFC v1 08/15] iommu: Add asid_bits to arm smmu-v3 stage1 table info Jean-Philippe Brucker
[not found] ` <20210115121342.15093-10-vivek.gautam@arm.com>
2021-03-03 17:21 ` [PATCH RFC v1 09/15] iommu/virtio: Update table format probing header Jean-Philippe Brucker
[not found] ` <20210115121342.15093-14-vivek.gautam@arm.com>
2021-03-03 17:25 ` [PATCH RFC v1 13/15] iommu/virtio: Attach Arm PASID tables when available Jean-Philippe Brucker
[not found] ` <ee88590b-513e-7821-ab52-18d496ad90dc@arm.com>
2021-03-29 16:21 ` Jean-Philippe Brucker
[not found] ` <20210115121342.15093-16-vivek.gautam@arm.com>
2021-03-03 17:25 ` [PATCH RFC v1 15/15] iommu/virtio: Update fault type and reason info for viommu fault Jean-Philippe Brucker
[not found] ` <d8a81406-12c6-a5e1-7297-49c1a0a800ab@arm.com>
2021-03-29 16:23 ` Jean-Philippe Brucker
[not found] ` <20210115121342.15093-13-vivek.gautam@arm.com>
[not found] ` <20210303102848.5d879f0e@jacob-builder>
2021-03-04 5:58 ` [PATCH RFC v1 12/15] iommu/virtio: Add support for INVALIDATE request Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8fd0176-3888-44cf-d659-2e2213a59969@redhat.com \
--to=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mst@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vivek.gautam@arm.com \
--cc=will.deacon@arm.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).