From: Jason Wang <jasowang@redhat.com>
To: Eli Cohen <elic@nvidia.com>,
mst@redhat.com, parav@nvidia.com, si-wei.liu@oracle.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 4/5] vdpa/mlx5: Fix wrong use of bit numbers
Date: Thu, 8 Apr 2021 17:46:45 +0800 [thread overview]
Message-ID: <f2ffac98-2ce7-f9c1-de93-09e9347d0991@redhat.com> (raw)
In-Reply-To: <20210408091047.4269-5-elic@nvidia.com>
在 2021/4/8 下午5:10, Eli Cohen 写道:
> VIRTIO_F_VERSION_1 is a bit number. Use BIT_ULL() with mask
> conditionals.
>
> Also, in mlx5_vdpa_is_little_endian() use BIT_ULL for consistency with
> the rest of the code.
>
> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
> Signed-off-by: Eli Cohen <elic@nvidia.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index a49ebb250253..6fe61fc57790 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -820,7 +820,7 @@ static int create_virtqueue(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtque
> MLX5_SET(virtio_q, vq_ctx, event_qpn_or_msix, mvq->fwqp.mqp.qpn);
> MLX5_SET(virtio_q, vq_ctx, queue_size, mvq->num_ent);
> MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0,
> - !!(ndev->mvdev.actual_features & VIRTIO_F_VERSION_1));
> + !!(ndev->mvdev.actual_features & BIT_ULL(VIRTIO_F_VERSION_1)));
> MLX5_SET64(virtio_q, vq_ctx, desc_addr, mvq->desc_addr);
> MLX5_SET64(virtio_q, vq_ctx, used_addr, mvq->device_addr);
> MLX5_SET64(virtio_q, vq_ctx, available_addr, mvq->driver_addr);
> @@ -1554,7 +1554,7 @@ static void clear_virtqueues(struct mlx5_vdpa_net *ndev)
> static inline bool mlx5_vdpa_is_little_endian(struct mlx5_vdpa_dev *mvdev)
> {
> return virtio_legacy_is_little_endian() ||
> - (mvdev->actual_features & (1ULL << VIRTIO_F_VERSION_1));
> + (mvdev->actual_features & BIT_ULL(VIRTIO_F_VERSION_1));
> }
>
> static __virtio16 cpu_to_mlx5vdpa16(struct mlx5_vdpa_dev *mvdev, u16 val)
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2021-04-08 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210408091047.4269-1-elic@nvidia.com>
2021-04-08 9:17 ` [PATCH 0/5] VDPA mlx5 fixes Greg KH
[not found] ` <20210408091047.4269-3-elic@nvidia.com>
2021-04-08 9:44 ` [PATCH 2/5] vdpa/mlx5: Use the correct dma device when registering memory Jason Wang
[not found] ` <20210408091047.4269-4-elic@nvidia.com>
2021-04-08 9:45 ` [PATCH 3/5] vdpa/mlx5: Retrieve BAR address suitable any function Jason Wang
[not found] ` <20210408091047.4269-6-elic@nvidia.com>
2021-04-08 9:45 ` [PATCH 5/5] vdpa/mlx5: Fix suspend/resume index restoration Jason Wang
[not found] ` <20210408091047.4269-5-elic@nvidia.com>
2021-04-08 9:46 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2ffac98-2ce7-f9c1-de93-09e9347d0991@redhat.com \
--to=jasowang@redhat.com \
--cc=elic@nvidia.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).