wireguard.lists.zx2c4.com archive mirror
 help / color / mirror / Atom feed
From: Matt Layher <mdlayher@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: Kernel module sends infinite netlink messages on v0.0.20180802
Date: Wed, 8 Aug 2018 23:54:36 -0400	[thread overview]
Message-ID: <6ee30b21-704c-f63b-b725-949497e38ecb@gmail.com> (raw)
In-Reply-To: <CAHmME9qyZQ-XQ0GDcoBAK8PdDr444Le5i0wq15un4oROKSj1AQ@mail.gmail.com>

I can confirm that this is fixed for me as of latest master:

$ dmesg | grep wireguard
[   50.396241] wireguard: module verification failed: signature and/or 
required key missing - tainting kernel
[   50.396675] wireguard: WireGuard 0.0.20180802-11-gc6505ee loaded. See 
www.wireguard.com for information.
[   50.396675] wireguard: Copyright (C) 2015-2018 Jason A. Donenfeld 
<Jason@zx2c4.com>. All Rights Reserved.

$ sudo ip link add dev wg0 type wireguard

$ sudo ./wgnlbug -n 2
before: wg0
  after: wg0
- peer: ZoJIpwr1iel/9emt2bNlnHhvasjZdmUD6v92Ry8z1Ro=: 0 IPs
- peer: y84s8m/91ryGV8tTQbycauYcukCjrAG1B8vx44BsxWM=: 511 IPs

$ sudo wg show
interface: wg0

peer: ZoJIpwr1iel/9emt2bNlnHhvasjZdmUD6v92Ry8z1Ro=
   allowed ips: (none)

peer: y84s8m/91ryGV8tTQbycauYcukCjrAG1B8vx44BsxWM=
   allowed ips: 2001:db8::1ff/128, 2001:db8::1fe/128, ...

Thanks for the quick patch.  I started with a pretty naive approach on 
my netlink message chunking implementation, but I'm glad I was able to 
help find a problem that way.

I'll be sure to report anything else I find, but at this point, I think 
I'm feature-complete for both userspace and kernel APIs.

- Matt


On 08/08/2018 10:20 PM, Jason A. Donenfeld wrote:
> On Wed, Aug 8, 2018 at 5:30 PM Matt Layher <mdlayher@gmail.com> wrote:
>> Excellent! That's much more concise.
> Let me know if this fixes it for you, and please do keep messing with
> weird cases to see if you can find more bugs. I really appreciate you
> finding this.
>
> https://git.zx2c4.com/WireGuard/commit/?id=fd60e07ba3e294b94985a42d11afebf55f1d8829

      reply	other threads:[~2018-08-09  3:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08 19:36 Kernel module sends infinite netlink messages on v0.0.20180802 Matt Layher
2018-08-09  0:11 ` Jason A. Donenfeld
2018-08-09  0:30   ` Matt Layher
2018-08-09  2:20     ` Jason A. Donenfeld
2018-08-09  3:54       ` Matt Layher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ee30b21-704c-f63b-b725-949497e38ecb@gmail.com \
    --to=mdlayher@gmail.com \
    --cc=Jason@zx2c4.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).