From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: "Lonnie Abelbeck" <lists@lonnie.abelbeck.com>,
"Luis Ressel" <aranea@aixah.de>,
"Steven Honson" <steven@honson.id.au>,
"Ivan Labáth" <labo@labo.rs>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: RFC: wg syncpeers wg0 wireguard.conf
Date: Fri, 14 Jun 2019 20:09:38 +0200 [thread overview]
Message-ID: <CAHmME9qpp5pkP3RAENJfWjdaL61T7J1C5dDLCM+OM-U_DxRz_Q@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9r3QVVWRu=36Yx6wmfuHm5CCA3Dg+JdZknpnNAmnj=ATQ@mail.gmail.com>
Hey Lonnie,
If your changes are user-facing, it's probably not a good idea to
create confusion by introducing distro-specific subcommands.
I'm leaning toward Steven's suggestion of nixing addconf and making
setconf behave like syncconf. But two hurdles remain:
- walk_remove_by_peer is very inefficient. That *must* be to be
improved for this to be feasible. There's some interesting algorithms
programming in allowedips.c to be tackled for that. Maybe
node->peer_list can be used. (CC'ing Ivan in case he wants to put his
mind to work on that.)
- A decision needs to be made on consistency: do we want to read back
the end result and compare it? Or will that kind of looping logic lead
to other types of DoS or latency spikes?
Jason
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
next prev parent reply other threads:[~2019-06-14 18:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 19:59 RFC: wg syncpeers wg0 wireguard.conf Lonnie Abelbeck
2019-06-10 12:34 ` Rene 'Renne' Bartsch, B.Sc. Informatics
2019-06-11 17:28 ` Jason A. Donenfeld
2019-06-11 21:06 ` Lonnie Abelbeck
2019-06-11 21:41 ` Kalin KOZHUHAROV
2019-06-12 0:22 ` Steven Honson
2019-06-12 0:25 ` Marc Fawzi
2019-06-14 18:01 ` Jason A. Donenfeld
2019-06-16 19:43 ` Marc Fawzi
2019-06-13 23:15 ` Lonnie Abelbeck
2019-06-14 18:09 ` Jason A. Donenfeld [this message]
2019-06-14 20:48 ` Lonnie Abelbeck
2019-06-14 21:14 ` Ivan Labáth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9qpp5pkP3RAENJfWjdaL61T7J1C5dDLCM+OM-U_DxRz_Q@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=aranea@aixah.de \
--cc=labo@labo.rs \
--cc=lists@lonnie.abelbeck.com \
--cc=steven@honson.id.au \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).