From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: cbranch@cloudflare.com,
WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: wireguard-go foreground mode broken on Linux
Date: Thu, 6 Dec 2018 17:40:58 +0100 [thread overview]
Message-ID: <CAHmME9quC_b3jh+9Z=SnqcXn4Eq+8JhC2ZO-Dz4fNGZPtOqRrA@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9oWo6dhFgw9eu6Cc0r_wp1v1-Le2b+H9asUP-UXDO=seA@mail.gmail.com>
On Thu, Dec 6, 2018 at 5:37 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> On Thu, Dec 6, 2018 at 5:31 PM Chris Branch <cbranch@cloudflare.com> wrote:
> > Your solution is the same one I tried, but I wasn't yet convinced it was the right one. I'll take it though!
>
> Did you run into issues with it? Or had particular doubts I should consider?
In case it helps in understanding this, the condition I'm trying to
enforce, rather than the hack that the fix commit removed, is that
rwcancel alone is responsible for calling SetNonblock, and after
rwcancel is instantiated, nobody calls .Fd() ever again, but instead
relies on the stored tun.fd member for access.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
prev parent reply other threads:[~2018-12-06 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 10:06 wireguard-go foreground mode broken on Linux Chris Branch
2018-12-06 16:18 ` Jason A. Donenfeld
[not found] ` <CAHmME9pyCqLvTOBHCFYttJJzYGSyf26Way1FmhUtr0NvB8jU6Q@mail.gmail.com>
[not found] ` <CAMhRzNQ6QwgGT4_LTrVrZ-8LL8bO=T5roFzLRdyGWwVHChvf2w@mail.gmail.com>
2018-12-06 16:37 ` Jason A. Donenfeld
2018-12-06 16:40 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9quC_b3jh+9Z=SnqcXn4Eq+8JhC2ZO-Dz4fNGZPtOqRrA@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=cbranch@cloudflare.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).