wireguard.lists.zx2c4.com archive mirror
 help / color / mirror / Atom feed
From: Samuel Holland <samuel@sholland.org>
To: Vasili Pupkin <diggest@gmail.com>, wireguard@lists.zx2c4.com
Subject: Re: [PATCH] Update Simplified Chinese translation
Date: Tue, 25 Feb 2020 21:59:17 -0600	[thread overview]
Message-ID: <bc47c4f7-4aa4-fc6e-8f3c-34366c756236@sholland.org> (raw)
In-Reply-To: <1eb99bf8-f07e-9b13-f543-017b14a3df5f@gmail.com>

On 2/25/20 9:44 PM, Vasili Pupkin wrote:
> On 26.02.2020 5:56, Samuel Holland wrote:
>> On 2/25/20 2:13 AM, Eiji Tanioka wrote:
>>> Hi Samuel.
>>>
>>> I already translated in Japanese, but I didn't concern about plurals.
>>>
>>> Japanese doesn't have plurals, so does "values-ja/strings.xml" needs these fix?
>>> - remove plurals
>>> - add string resource that have same "name" attribute as plurals
>> Resources that have <plural> tags in the untranslated XML should use <plural> in
>> translations as well. However, the only <item> tag inside them should be
>> "other". (It should look like the Chinese translation did before this patch.)
>>
>> So the only thing to fix is removing the <item quantity="one"> tags.
> 
> It seams that russian translation is very basic and not utilize quantity="two"
> and quantity="few" forms, without them some plurals reads odd. Do you need help
> fixing it or it is done on purpose?

I don't think it was done on purpose; likely the translator was unaware of the
additional options for quantity in <item> tags. I am happy to merge patches
improving the translation (which is really up to your judgement, since I don't
speak any of these languages).

Thanks,
Samuel
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

  reply	other threads:[~2020-02-26  3:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-23 11:12 [PATCH] Update Simplified Chinese translation srb12345
2020-02-25  0:56 ` Samuel Holland
2020-02-25  8:13   ` Eiji Tanioka
2020-02-26  2:56     ` Samuel Holland
2020-02-26  3:10       ` Eiji Tanioka
2020-02-26  3:44       ` Vasili Pupkin
2020-02-26  3:59         ` Samuel Holland [this message]
2020-02-29  7:00           ` Vasili Pupkin
2020-02-29  8:35             ` Eiji Tanioka
2020-02-29  8:54               ` Jason A. Donenfeld
     [not found]               ` <5428f486-49cd-0321-de5b-9ef6ca3e8dad@gmail.com>
2020-03-01  6:53                 ` Eiji Tanioka
2020-03-01  7:00                   ` Jason A. Donenfeld
2020-02-26  3:21 =?gb18030?B?TWF0c3VyaQ==?=
2020-03-12 11:40 srb12345
2020-03-12 11:47 ` Harsh Shandilya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc47c4f7-4aa4-fc6e-8f3c-34366c756236@sholland.org \
    --to=samuel@sholland.org \
    --cc=diggest@gmail.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).