workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Daniel Axtens <dja@axtens.net>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
	workflows@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Jiri Kosina <jikos@kernel.org>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: Kernel development collaboration platform wish list
Date: Thu, 03 Oct 2019 11:23:28 +0200	[thread overview]
Message-ID: <1881738.6USjZhhSkN@kreacher> (raw)
In-Reply-To: <87pnjf2pnw.fsf@dja-thinkpad.axtens.net>

On Wednesday, October 2, 2019 4:22:11 PM CEST Daniel Axtens wrote:
> "Rafael J. Wysocki" <rjw@rjwysocki.net> writes:
> 
> > On Monday, September 23, 2019 6:20:01 PM CEST Theodore Y. Ts'o wrote:
> >> One of the things I'd like to add as a strong desire is the ability to
> >> review patches via web if that's what users would like to do.  There
> >> are some real benefits for web-based review.  It means that if you
> >> need to see greater context, it's relatively easy to do this.  It also
> >> is convenient to be able to see the conversation for a particular hunk
> >> of code right alongside the code.
> >
> > I totally agree.
> >
> > That may not be clear from my original posting (sorry about that), but it
> > was my basic assumption that the web-based functionality would be there.
> >
> >> It's clear that whatever we do, it needs to be compatible with e-mail.
> >> That's very clear.  But it would be useful if we can support both the
> >> e-mail and web-based review.
> >
> > Right.
> 
> A long time ago now (before I was involved) there was talk of extending
> patchwork to allow logged in users to comment on a patch in the web UI
> and have patchwork send the comment as an email on your behalf.

I actually would appreciate something like that. :-)

Today, if I look at a patch in Patchwork and want to make comments on it, I
need to find it in an email client and do that from there which at least is
somewhat cumbersome.

> This was in the happier(?) days before we had SPF and DMARC, so I don't know
> how feasible it would be today. (Maybe the emails would just have to come
> from 'Patchwork on behalf of J. R. Developer'.)

That would work for me.

> But could web-based review be as simple as a web form that sends an email?

That might work too I suppose, but I would like it to open up with the body of
the message I'm replaying to quoted with "> " (so things don't need to be
copied from there by hand).

> (I'm not advocating that this be put in patchwork straight away or
> necessarily at all, but I think a proof of concept that lives off to the
> side of patchwork could be an excellent use of the patchwork API!)

Sure.

Cheers,
Rafael




      reply	other threads:[~2019-10-03  9:23 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13  8:22 Kernel development collaboration platform wish list Rafael J. Wysocki
2019-09-13 11:13 ` Jani Nikula
2019-09-17 21:58   ` Rafael J. Wysocki
2019-09-18  8:05     ` Jani Nikula
2019-09-18 13:43       ` Steven Rostedt
2019-09-13 11:37 ` Laurent Pinchart
2019-09-13 12:02   ` Geert Uytterhoeven
2019-09-13 12:15     ` Laurent Pinchart
2019-09-13 12:23       ` Geert Uytterhoeven
2019-09-17 22:00         ` Rafael J. Wysocki
2019-10-02  9:30   ` Rafael J. Wysocki
2019-09-17 18:40 ` Stefan Schmidt
2019-09-24  9:43   ` Paolo Bonzini
2019-09-24 12:20     ` Stefan Schmidt
2019-09-17 22:12 ` Rafael J. Wysocki
2019-10-01  3:52   ` Daniel Axtens
2019-10-01  4:50     ` Andrew Donnellan
2019-10-01  5:04       ` Daniel Axtens
2019-09-23 16:20 ` Theodore Y. Ts'o
2019-09-24  1:39   ` Eric Wong
2019-09-24  5:06     ` Greg Kroah-Hartman
2019-10-01  3:58     ` Daniel Axtens
2019-09-26 10:18   ` Geert Uytterhoeven
2019-09-26 11:40     ` Steven Rostedt
2019-09-26 13:39       ` Geert Uytterhoeven
2019-09-28 22:16         ` Steven Rostedt
2019-09-29 16:03           ` Dmitry Vyukov
2019-09-26 13:10     ` Jani Nikula
2019-09-26 13:41       ` Geert Uytterhoeven
2019-09-26 14:40         ` Jani Nikula
2019-10-02  9:55   ` Rafael J. Wysocki
2019-10-02 14:22     ` Daniel Axtens
2019-10-03  9:23       ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1881738.6USjZhhSkN@kreacher \
    --to=rjw@rjwysocki.net \
    --cc=dja@axtens.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=helgaas@kernel.org \
    --cc=jikos@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tytso@mit.edu \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).