From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Greg KH <gregkh@linuxfoundation.org>, Eric Wong <e@80x24.org>,
workflows@vger.kernel.org
Subject: Re: patch attachments still unwelcome?
Date: Tue, 5 Nov 2019 11:46:30 +0100 [thread overview]
Message-ID: <CAMuHMdXDwMkAyg5thonW-Tt9RX2DNVe3bPd+hVFhtXY7_p8eMA@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdXFRx6f1PqAqCxDJn4gpr4+HiHZTn3tuS=_Yq92j_Lzeg@mail.gmail.com>
Hi Jani,
On Mon, Nov 4, 2019 at 6:40 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, Nov 4, 2019 at 3:52 PM Jani Nikula <jani.nikula@intel.com> wrote:
> > Typically you'd have a multipart/mixed MIME message with several parts
> > of various Content-Types. In this case presumably text/plain, but
> > text/x-diff is not out of the question for patches. Also seen a lot of
> > application/octet-stream for logs.
> >
> > You can give a *hint* to the recipient MUA on how to interpret each part
> > by setting Content-Disposition: attachment or inline. Bottom line,
> > whether you can control that in your MUA, and whether the recipient MUA
> > actually respects that is anyone's guess.
> >
> > For fun, this multipart message contains three parts, the one you're
> > reading, and two additional parts, one of which should be inline and the
> > other one an attachment.
>
> So the Gmail web interface shows both as attachments, but can show
> the contents when I click on them.
> The Gmail Android app shows both as attachments, and forces me to
> download the attachments to read them, using a selected app.
Just for fun, I tried alpine, which I still use from time to time.
Alpine shows the first one "sort of" inline, at the bottom:
| --
| Jani Nikula, Intel Open Source Graphics Center
|
|
| [ Part 2: "Attached Text" ]
|
| This is supposed to be inline.
|
|
| [ Part 3, Text/PLAIN 2 lines. ]
| [ Not Shown. Use the "V" command to view or save this part. ]
But when replying, the "inline" one is not quoted, so I can't provide
review comments.
> Ergo, no attachments is the safest.
Unless your patches are perfect, and will receive no comments but
RoB or AB tags ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-11-05 10:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 2:27 patch attachments still unwelcome? Eric Wong
2019-11-01 9:04 ` Greg KH
2019-11-04 13:13 ` Theodore Y. Ts'o
2019-11-04 13:23 ` Dmitry Vyukov
2019-11-04 14:49 ` Jani Nikula
2019-11-04 17:40 ` Geert Uytterhoeven
2019-11-05 10:46 ` Geert Uytterhoeven [this message]
2019-11-04 13:42 ` Greg KH
2019-11-04 13:42 ` Drew DeVault
2019-11-01 13:00 ` Konstantin Ryabitsev
2019-11-04 11:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXDwMkAyg5thonW-Tt9RX2DNVe3bPd+hVFhtXY7_p8eMA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=dvyukov@google.com \
--cc=e@80x24.org \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@intel.com \
--cc=tytso@mit.edu \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).