From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADFABC433E0 for ; Thu, 30 Jul 2020 18:30:04 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D5AC20829 for ; Thu, 30 Jul 2020 18:30:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MEUeLJfQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D5AC20829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1DJQ-0004X1-49; Thu, 30 Jul 2020 18:29:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1DJO-0004Wm-JR for xen-devel@lists.xenproject.org; Thu, 30 Jul 2020 18:29:50 +0000 X-Inumbo-ID: a6b7ac09-d292-11ea-8db4-bc764e2007e4 Received: from mail-wm1-x341.google.com (unknown [2a00:1450:4864:20::341]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a6b7ac09-d292-11ea-8db4-bc764e2007e4; Thu, 30 Jul 2020 18:29:49 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id p14so6568072wmg.1 for ; Thu, 30 Jul 2020 11:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=/oQ2B/nA5GJoZwORYhxmg1CGViXflM1e2jiWcV2alIE=; b=MEUeLJfQhbMl2ymOXA24n4PxsLgYpsVwSjLBNJTxUwcL/HSofd5QMX+f01esEH79U8 jIMgEEidPlJQarh1xEKZX4WwANvU0GDN6ZnK2vPhYbBNiInbx0znkhwo+nZwb/3BYhKy dacx2oUSlXEXmoJyncT1WFtg36WiSTaC4aAt0YAhcC0Yqx5KiOyQdF5QhArW9HT8KF7U Xax+c6lkoUYbi4qLZs/8DWfVdOq8hEG+DQQ9d+jWB82pfxh8bPzKr1sQjeCufoKWlOIl 6KVnyVgHg1ugIvkNMPwrZQAxKsZ1DJBRmJ3NXu6yn8aDJx15YElqjC4qirg0/hDQOj63 hBWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=/oQ2B/nA5GJoZwORYhxmg1CGViXflM1e2jiWcV2alIE=; b=TANALuklAkbxUcSlzP0R+bIXgLB5jIj+AzNOgDt+61TmG2cxcbhAYW0XIbIyA2YNiT tuEiwzAizZvMT9HSuHaiigQ52LaVTFiq1pFJraN/3WGQ+Tp7F6pQFerto2UMhTgyAoLB iuRJ72+YdKfAZhNr04dsC5zoemlEn4tMpfTsgTNwaGxotZLa9VaxTMxpajz8dM51IO56 Bdm+LBK5IukH8cEd1wCkerfKExbOgY1dvMHHO4E10REn1FLN5l0twGcEh+xJ/Rwev+jj DxPVvY16iM7KZ5J5fyBe8InMjDXLjOBfEJZkqUdXrzV3jsVuStqpd1o+TGzzj3XWgBnV Ciug== X-Gm-Message-State: AOAM531h0oNW45E4oulmLxxfa57DMGuF8Lk15S3mKDtlcVh79fnuz8VD 8hETyBJaXjS1kGbhwbaeJr8= X-Google-Smtp-Source: ABdhPJwJ5JfmPslQwuRXUb66cXv4PAirCb1OjMzodPGqKFQ/dxT4SOW6am0FgccGpgNJrPjJWA/esg== X-Received: by 2002:a05:600c:284:: with SMTP id 4mr513155wmk.48.1596133788881; Thu, 30 Jul 2020 11:29:48 -0700 (PDT) Received: from CBGR90WXYV0 ([2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec]) by smtp.gmail.com with ESMTPSA id 31sm10855810wrp.87.2020.07.30.11.29.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jul 2020 11:29:48 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Andrew Cooper'" , "'Xen-devel'" References: <20200728113712.22966-1-andrew.cooper3@citrix.com> <20200728113712.22966-2-andrew.cooper3@citrix.com> <002601d66647$ca8567e0$5f9037a0$@xen.org> <33a10589-6890-b653-d8c2-7eb19a5e4929@citrix.com> In-Reply-To: <33a10589-6890-b653-d8c2-7eb19a5e4929@citrix.com> Subject: RE: [PATCH 1/5] xen/memory: Introduce CONFIG_ARCH_ACQUIRE_RESOURCE Date: Thu, 30 Jul 2020 19:24:35 +0100 Message-ID: <003301d6669e$addc2500$09946f00$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQF6ExwjYkgZ+OK4ROtT1vtJIEnjiAIw/yGXAh+jJtsCDzS7HKmmGCIw X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Stefano Stabellini' , 'Julien Grall' , 'Wei Liu' , =?utf-8?Q?'Micha=C5=82_Leszczy=C5=84ski'?= , 'Jan Beulich' , 'Hubert Jasudowicz' , 'Volodymyr Babchuk' , =?utf-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Andrew Cooper > Sent: 30 July 2020 18:34 > To: paul@xen.org; 'Xen-devel' > Cc: 'Jan Beulich' ; 'Wei Liu' ; 'Roger = Pau Monn=C3=A9' > ; 'Stefano Stabellini' ; = 'Julien Grall' > ; 'Volodymyr Babchuk' ; = 'Micha=C5=82 Leszczy=C5=84ski' > ; 'Hubert Jasudowicz' = > Subject: Re: [PATCH 1/5] xen/memory: Introduce = CONFIG_ARCH_ACQUIRE_RESOURCE >=20 > On 30/07/2020 09:02, Paul Durrant wrote: > >> -----Original Message----- > >> From: Andrew Cooper > >> Sent: 28 July 2020 12:37 > >> To: Xen-devel > >> Cc: Andrew Cooper ; Jan Beulich = ; Wei Liu > ; > >> Roger Pau Monn=C3=A9 ; Stefano Stabellini = ; Julien Grall > >> ; Volodymyr Babchuk ; = Paul Durrant ; > Micha=C5=82 > >> Leszczy=C5=84ski ; Hubert Jasudowicz = > >> Subject: [PATCH 1/5] xen/memory: Introduce = CONFIG_ARCH_ACQUIRE_RESOURCE > >> > >> New architectures shouldn't be forced to implement no-op stubs for = unused > >> functionality. > >> > >> Introduce CONFIG_ARCH_ACQUIRE_RESOURCE which can be opted in to, = and provide > >> compatibility logic in xen/mm.h > >> > >> No functional change. > > Code-wise, it looks fine, so... > > > > Reviewed-by: Paul Durrant >=20 > Thanks, >=20 > > > > ...but ... > > > >> Signed-off-by: Andrew Cooper > >> --- > >> CC: Jan Beulich > >> CC: Wei Liu > >> CC: Roger Pau Monn=C3=A9 > >> CC: Stefano Stabellini > >> CC: Julien Grall > >> CC: Volodymyr Babchuk > >> CC: Paul Durrant > >> CC: Micha=C5=82 Leszczy=C5=84ski > >> CC: Hubert Jasudowicz > >> --- > >> xen/arch/x86/Kconfig | 1 + > >> xen/common/Kconfig | 3 +++ > >> xen/include/asm-arm/mm.h | 8 -------- > >> xen/include/xen/mm.h | 9 +++++++++ > >> 4 files changed, 13 insertions(+), 8 deletions(-) > >> > >> diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig > >> index a636a4bb1e..e7644a0a9d 100644 > >> --- a/xen/arch/x86/Kconfig > >> +++ b/xen/arch/x86/Kconfig > >> @@ -6,6 +6,7 @@ config X86 > >> select ACPI > >> select ACPI_LEGACY_TABLES_LOOKUP > >> select ARCH_SUPPORTS_INT128 > >> + select ARCH_ACQUIRE_RESOURCE > > ... I do wonder whether 'HAS_ACQUIRE_RESOURCE' is a better and more = descriptive name. >=20 > We don't have a coherent policy for how to categorise these things. I > can change the name if you insist, but I'm not sure it makes a useful > difference. >=20 Ok, it's fine. My R-b stands. Paul > ~Andrew