From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
Andrii Anisov <Andrii_Anisov@epam.com>,
Oleksandr_Tyshchenko@epam.com
Subject: Re: [Xen-devel] [PATCH MM-PART3 v2 06/12] xen/arm: mm: Sanity check any update of Xen page tables
Date: Wed, 12 Jun 2019 16:58:19 +0100 [thread overview]
Message-ID: <0ac90607-49b3-1b9d-0796-daab8d6e0c02@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1906120853050.13737@sstabellini-ThinkPad-T480s>
Hi,
On 12/06/2019 16:54, Stefano Stabellini wrote:
> On Wed, 12 Jun 2019, Julien Grall wrote:
>> On 12/06/2019 01:10, Stefano Stabellini wrote:
>>> On Tue, 14 May 2019, Julien Grall wrote:
>>> I understand we could skip the valid check on REMOVE, but should we skip
>>> it on MODIFY too? Is that also going to be helpful in future changes?
>>
>> Hmmm, I can't exactly remember why I didn't check the valid bit here.
>>
>> I did it for REMOVE as for the early FDT mapping it is more convenient to
>> remove the full possible range over keeping track of the exact start/size.
>>
>> I would assume the same would hold for MODIFY, but I don't have a concrete
>> example here. I am happy to add the valid check and defer the decision to
>> remove it if it is deem to be useful in the future.
>
> Yes, it would be better
I will update it in the next version.
[...]
>>>> static int xen_pt_update_entry(enum xenmap_operation op, unsigned long
>>>> addr,
>>>> mfn_t mfn, unsigned int flags)
>>>> {
>>>> lpae_t pte, *entry;
>>>> lpae_t *third = NULL;
>>>> + /* _PAGE_POPULATE and _PAGE_PRESENT should never be set together.
>>>> */
>>>> + ASSERT((flags & (_PAGE_POPULATE|_PAGE_PRESENT)) !=
>>>> (_PAGE_POPULATE|_PAGE_PRESENT));
>>>
>>> over 80 chars?
>>
>> It is 87 chars, I was hoping you didn't notice it :). The line splitting
>> result to nasty code. Alternatively, I could introduce a define for
>> _PAGE_POPULATE|_PAGE_PRESENT, maybe EXCLUSIVE_FLAGS?
>>
>> Any preference?
>
> I don't care so much about 80 chars limit.
> Anything but another macro :-)
Ok I will keep the 80 lines then!
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-12 15:58 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 12:31 [PATCH MM-PART3 v2 00/12] xen/arm: Provide a generic function to update Xen PT Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-05-14 12:31 ` [PATCH MM-PART3 v2 01/12] xen/arm: lpae: Add a macro to generate offsets from an address Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:21 ` Stefano Stabellini
2019-06-11 18:27 ` Julien Grall
2019-05-14 12:31 ` [PATCH MM-PART3 v2 02/12] xen/arm: mm: Rename create_xen_entries() to xen_pt_update() Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:23 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 03/12] xen/arm: mm: Move out of xen_pt_update() the logic to update an entry Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:29 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 04/12] xen/arm: mm: Only increment mfn when valid in xen_pt_update Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:37 ` Stefano Stabellini
2019-06-11 19:56 ` [Xen-devel] Checking INVALID_MFN in mfn_add (WAS: Re: [PATCH MM-PART3 v2 04/12] xen/arm: mm: Only increment mfn when valid in xen_pt_update) Julien Grall
2019-06-11 20:24 ` Andrew Cooper
2019-06-12 12:47 ` Julien Grall
2019-06-12 15:57 ` Stefano Stabellini
2019-06-12 7:53 ` Jan Beulich
2019-05-14 12:31 ` [PATCH MM-PART3 v2 05/12] xen/arm: mm: Introduce _PAGE_PRESENT and _PAGE_POPULATE Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 22:35 ` Stefano Stabellini
2019-06-12 13:00 ` Julien Grall
2019-05-14 12:31 ` [PATCH MM-PART3 v2 06/12] xen/arm: mm: Sanity check any update of Xen page tables Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 0:10 ` Stefano Stabellini
2019-06-12 14:48 ` Julien Grall
2019-06-12 15:54 ` Stefano Stabellini
2019-06-12 15:58 ` Julien Grall [this message]
2019-05-14 12:31 ` [PATCH MM-PART3 v2 07/12] xen/arm: mm: Rework xen_pt_update_entry to avoid use xenmap_operation Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:22 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 08/12] xen/arm: mm: Remove enum xenmap_operation Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 22:38 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 09/12] xen/arm: mm: Use {, un}map_domain_page() to map/unmap Xen page-tables Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:25 ` Stefano Stabellini
2019-06-13 8:07 ` Julien Grall
2019-06-13 17:55 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 10/12] xen/arm: mm: Rework Xen page-tables walk during update Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:52 ` Stefano Stabellini
2019-06-13 8:20 ` Julien Grall
2019-06-13 17:59 ` Stefano Stabellini
2019-06-13 21:32 ` Julien Grall
2019-06-13 22:57 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 11/12] xen/arm: mm: Don't open-code Xen PT update in {set, clear}_fixmap() Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:33 ` Stefano Stabellini
2019-06-13 8:31 ` Julien Grall
2019-06-13 18:51 ` Stefano Stabellini
2019-06-13 21:21 ` Julien Grall
2019-06-13 22:55 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 12/12] xen/arm: mm: Remove set_pte_flags_on_range() Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:41 ` Stefano Stabellini
2019-06-13 8:51 ` Julien Grall
2019-06-13 18:04 ` Stefano Stabellini
2019-06-13 21:22 ` Julien Grall
2019-05-29 17:23 ` [PATCH MM-PART3 v2 00/12] xen/arm: Provide a generic function to update Xen PT Julien Grall
2019-05-29 17:23 ` [Xen-devel] " Julien Grall
2019-06-10 10:08 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ac90607-49b3-1b9d-0796-daab8d6e0c02@arm.com \
--to=julien.grall@arm.com \
--cc=Andrii_Anisov@epam.com \
--cc=Oleksandr_Tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).