From: Ian Campbell <ian.campbell@citrix.com>
To: Jonathan Creekmore <jonathan.creekmore@gmail.com>,
xen-devel@lists.xenproject.org
Cc: dave.scott@eu.citrix.com
Subject: Re: [PATCH] oxenstored: link in the systemd system library
Date: Thu, 23 Jul 2015 09:41:54 +0100 [thread overview]
Message-ID: <1437640914.19412.33.camel@citrix.com> (raw)
In-Reply-To: <1437602559-12233-1-git-send-email-jonathan.creekmore@gmail.com>
On Wed, 2015-07-22 at 17:02 -0500, Jonathan Creekmore wrote:
> If systemd is configured for use AND you are building oxenstored, the
> C
> systemd library must be linked in to the oxenstored binary instead of
> just into the static ocaml stub.
I can't see where it is linked into the static ocaml stub at all,
compared with tools/ocaml/libs/* there is no LIBS_systemd declared in
tools/ocaml/xenstore/Makefile. AIUI this is supposed to cause the
underlying library to be referenced by the cxma such that you don't
need it at application link time.
It's also the case that we don't seem to link xenstored against any
other libraries in this way, they get picked up via the cxma.
So I think the right fix is probably to set LIBS_systemd, or otherwise
arrange for this argument to be used when creating the systemd.cxma.
Ian.
>
> Signed-off-by: Jonathan Creekmore <jonathan.creekmore@gmail.com>
> ---
> tools/ocaml/xenstored/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/ocaml/xenstored/Makefile
> b/tools/ocaml/xenstored/Makefile
> index d861f11..38ca347 100644
> --- a/tools/ocaml/xenstored/Makefile
> +++ b/tools/ocaml/xenstored/Makefile
> @@ -64,9 +64,11 @@ XENSTOREDLIBS = \
> -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xb
> $(OCAML_TOPLEVEL)/libs/xb/xenbus.cmxa \
> -ccopt -L -ccopt $(XEN_ROOT)/tools/libxc
>
> +XENSTORED_LDFLAGS-$(CONFIG_SYSTEMD) += -cclib $(SYSTEMD_LIBS)
> +
> PROGRAMS = oxenstored
>
> -oxenstored_LIBS = $(XENSTOREDLIBS)
> +oxenstored_LIBS = $(XENSTOREDLIBS) $(XENSTORED_LDFLAGS-y)
> oxenstored_OBJS = $(OBJS)
>
> OCAML_PROGRAM = oxenstored
next prev parent reply other threads:[~2015-07-23 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 22:02 [PATCH] oxenstored: link in the systemd system library Jonathan Creekmore
2015-07-23 8:41 ` Ian Campbell [this message]
2015-07-23 13:40 ` [PATCH v2] " Jonathan Creekmore
2015-07-23 14:00 ` Ian Campbell
2015-07-23 14:03 ` Jonathan Creekmore
2015-07-23 14:06 ` Ian Campbell
2015-07-24 11:04 ` Ian Campbell
2015-07-23 9:02 ` [PATCH] " Dave Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437640914.19412.33.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=dave.scott@eu.citrix.com \
--cc=jonathan.creekmore@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).