From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 09/10] sg-report-job-history: Introduce report_altchangecolour
Date: Thu, 23 Jul 2015 19:19:23 +0100 [thread overview]
Message-ID: <1437675564-16602-10-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1437675564-16602-1-git-send-email-ian.jackson@eu.citrix.com>
No functional change.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
Osstest/Executive.pm | 12 ++++++++++++
sg-report-job-history | 10 +++-------
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index 998a0d0..79d433a 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -48,6 +48,7 @@ BEGIN {
findtask @all_lock_tables
restrictflight_arg restrictflight_cond
report_run_getinfo report_altcolour
+ report_altchangecolour
report_blessingscond report_find_push_age_info
tcpconnect_queuedaemon plan_search
alloc_resources alloc_resources_rollback_begin_work
@@ -280,6 +281,17 @@ sub report_altcolour ($) {
return "bgcolor=\"#".(qw(d0d0d0 ffffff))[$bool]."\"";
}
+sub report_altchangecolour ($$) {
+ my ($stateref, $thisvalue) = @_;
+ my $state = $$stateref //= { Bool => 0 };
+ my $same =
+ !!defined($thisvalue) == !!defined($state->{LastValue}) &&
+ (!defined $thisvalue || $thisvalue eq $state->{LastValue});
+ $state->{Bool} ^= !$same;
+ $state->{LastValue} = $thisvalue;
+ return report_altcolour($state->{Bool});
+}
+
sub report_blessingscond ($) {
my ($blessings) = @_;
my $flightcond= restrictflight_cond();
diff --git a/sg-report-job-history b/sg-report-job-history
index e8cf50f..11fdaaf 100755
--- a/sg-report-job-history
+++ b/sg-report-job-history
@@ -231,7 +231,7 @@ END
print H "</tr>\n";
my $alternate= 0;
my @last_revs;
- my @alt_revs= ('0')x $#rev_grid_cols;
+ my @alt_revs;
foreach my $r (@test_rows) {
my $altcolour= report_altcolour($alternate);
print H "<tr $altcolour>";
@@ -263,12 +263,8 @@ END
"</td>\n";
foreach my $i (0..$#rev_grid_cols) {
my $v= $r->{Revisions}[$i];
- my $same=
- !defined($last_revs[$i]) ? !defined($v) :
- !defined($v) ? 0 :
- $last_revs[$i] eq $v;
- $alt_revs[$i] ^= !$same;
- print H "<td ".report_altcolour($alt_revs[$i]).">";
+ my $rev_colour = report_altchangecolour(\$alt_revs[$i], $v);
+ print H "<td $rev_colour>";
if (defined $v) {
my $vp= $v;
if (defined $lastrev && $v eq $lastrev) {
--
1.7.10.4
next prev parent reply other threads:[~2015-07-23 18:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 18:19 [OSSTEST PATCH 00/10] Bisection fix and reporting improvements Ian Jackson
2015-07-23 18:19 ` [OSSTEST PATCH 01/10] Flight restriction: Move $maxflight to Osstest::Executive Ian Jackson
2015-07-24 9:20 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 02/10] Flight restriction: Introduce restrictflight_arg and restrictflight_cond Ian Jackson
2015-07-24 9:21 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 03/10] Flight restriction: Update cs-bisection-step Ian Jackson
2015-07-24 9:21 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 04/10] Flight restriction: Update sg-report-flight and sg-report-job-history Ian Jackson
2015-07-24 9:22 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 05/10] Flight restriction: Make report_blessingscond use implicit $maxflight Ian Jackson
2015-07-24 9:24 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 06/10] Flight restriction: Change implementation of --max-flight Ian Jackson
2015-07-24 9:24 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 07/10] Flight restriction: Honour --exclude-flights=F1, F2, Ian Jackson
2015-07-24 9:25 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 08/10] cs-bisection-step: Fix memoisation of search_compute_length_at Ian Jackson
2015-07-24 9:26 ` Ian Campbell
2015-07-24 10:57 ` Ian Jackson
2015-07-24 11:09 ` Ian Campbell
2015-07-23 18:19 ` Ian Jackson [this message]
2015-07-24 9:27 ` [OSSTEST PATCH 09/10] sg-report-job-history: Introduce report_altchangecolour Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 10/10] sg-report-job-history: Colour host column according to whether it changes Ian Jackson
2015-07-24 9:28 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437675564-16602-10-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).