From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v6 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler Date: Wed, 9 Mar 2016 18:09:27 +0100 Message-ID: <1457543367.3102.438.camel@citrix.com> References: <1457286958-5427-1-git-send-email-lichong659@gmail.com> <1457286958-5427-4-git-send-email-lichong659@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8134800379974996536==" Return-path: In-Reply-To: <1457286958-5427-4-git-send-email-lichong659@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Chong Li , xen-devel@lists.xen.org Cc: Chong Li , wei.liu2@citrix.com, Sisu Xi , george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com, Meng Xu , dgolomb@seas.upenn.edu List-Id: xen-devel@lists.xenproject.org --===============8134800379974996536== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-elpyy9yo6+JdEGX9G0/J" --=-elpyy9yo6+JdEGX9G0/J Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On the whole series, you are Cc-ing=C2=A0ian.campbell@eu.citrix.com, which is no longer a tools maintainer. Please, double check by looking at MAINTAINERS and/or with ./scripts/get_maintainer.pl. While fiddling with the Cc-list, can you please try to arrange things in such a way that each person is Cc-ed only to the subset of the series that he would reasonably care about. For instance, Jan is likely not going to look at libxl and xl stuff, so no need bothering him with that. Similarly, IanJ wouldn't probably look at hypervisor stuff. If you are in doubt, stick to MAINTAINERS, with the exception that, if some random person commented on vX, he should be Cc-ed to vX+1, where the comments are addressed, no matter what he/she maintains. There are other exceptions, actually. For example, it's ok to Cc me to the whole series. This is hard to "set in stone", so again, if in doubt, follow the rule above... If people are interested in a patch that they happen not to be Cc-ed to, they'll find it via the mailing list. On Sun, 2016-03-06 at 11:55 -0600, Chong Li wrote: >=C2=A0 > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > index bd3aac8..4532e86 100644 > --- a/tools/libxl/libxl.c > +++ b/tools/libxl/libxl.c > @@ -5770,6 +5770,207 @@ static int sched_credit2_domain_set(libxl__gc > *gc, uint32_t domid, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 0; > =C2=A0} > =C2=A0 > +static int sched_rtds_validate_params(libxl__gc *gc, int period, > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0int bu= dget, uint32_t > *sdom_period, > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uint32= _t *sdom_budget) > +{ > +=C2=A0=C2=A0=C2=A0=C2=A0int rc =3D 0; > Empty line here (between local variables and code). Also, libxl coding style says: =C2=A0 * If the function is to return a libxl error value, `rc' is =C2=A0=C2=A0=C2=A0=C2=A0used to contain the error code, but it is NOT initi= alised: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0int= rc; This, in addition to all what Wei pointed out, to mean that, although things are certainly improving, some non negligible amount of coding style issues needs fixing. (I'll elaborate more, and more in general, in another email.) Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-elpyy9yo6+JdEGX9G0/J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlbgWMcACgkQk4XaBE3IOsQ3LQCfYL+qsl0ouk5COFq5JR7iU2mh A50Ani5rQlJ1yAD1IxM2/AQ/KEMrffXQ =dXTQ -----END PGP SIGNATURE----- --=-elpyy9yo6+JdEGX9G0/J-- --===============8134800379974996536== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============8134800379974996536==--