From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
jdelvare@suse.com, peterz@infradead.org, hpa@zytor.com,
x86@kernel.org, mingo@redhat.com, david.vrabel@citrix.com,
Douglas_Warzecha@dell.com, pali.rohar@gmail.com,
boris.ostrovsky@oracle.com, tglx@linutronix.de,
linux@roeck-us.net
Subject: [PATCH 3/6] dcdbas: make use of call_sync_on_phys_cpu()
Date: Fri, 11 Mar 2016 12:59:31 +0100 [thread overview]
Message-ID: <1457697574-6710-4-git-send-email-jgross__32514.6098075949$1457697664$gmane$org@suse.com> (raw)
In-Reply-To: <1457697574-6710-1-git-send-email-jgross@suse.com>
Use call_sync_on_phys_cpu() to raise SMI on cpu 0.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
drivers/firmware/dcdbas.c | 46 ++++++++++++++++++++--------------------------
1 file changed, 20 insertions(+), 26 deletions(-)
diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
index 829eec8..659c616 100644
--- a/drivers/firmware/dcdbas.c
+++ b/drivers/firmware/dcdbas.c
@@ -238,33 +238,14 @@ static ssize_t host_control_on_shutdown_store(struct device *dev,
return count;
}
-/**
- * dcdbas_smi_request: generate SMI request
- *
- * Called with smi_data_lock.
- */
-int dcdbas_smi_request(struct smi_cmd *smi_cmd)
+static int raise_smi(void *par)
{
- cpumask_var_t old_mask;
- int ret = 0;
+ struct smi_cmd *smi_cmd = par;
- if (smi_cmd->magic != SMI_CMD_MAGIC) {
- dev_info(&dcdbas_pdev->dev, "%s: invalid magic value\n",
- __func__);
- return -EBADR;
- }
-
- /* SMI requires CPU 0 */
- if (!alloc_cpumask_var(&old_mask, GFP_KERNEL))
- return -ENOMEM;
-
- cpumask_copy(old_mask, ¤t->cpus_allowed);
- set_cpus_allowed_ptr(current, cpumask_of(0));
if (smp_processor_id() != 0) {
dev_dbg(&dcdbas_pdev->dev, "%s: failed to get CPU 0\n",
__func__);
- ret = -EBUSY;
- goto out;
+ return -EBUSY;
}
/* generate SMI */
@@ -280,10 +261,23 @@ int dcdbas_smi_request(struct smi_cmd *smi_cmd)
: "memory"
);
-out:
- set_cpus_allowed_ptr(current, old_mask);
- free_cpumask_var(old_mask);
- return ret;
+ return 0;
+}
+/**
+ * dcdbas_smi_request: generate SMI request
+ *
+ * Called with smi_data_lock.
+ */
+int dcdbas_smi_request(struct smi_cmd *smi_cmd)
+{
+ if (smi_cmd->magic != SMI_CMD_MAGIC) {
+ dev_info(&dcdbas_pdev->dev, "%s: invalid magic value\n",
+ __func__);
+ return -EBADR;
+ }
+
+ /* SMI requires CPU 0 */
+ return call_sync_on_phys_cpu(0, raise_smi, smi_cmd);
}
/**
--
2.6.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-11 11:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1457697574-6710-1-git-send-email-jgross@suse.com>
2016-03-11 11:59 ` [PATCH 1/6] xen: sync xen header Juergen Gross
2016-03-11 11:59 ` [PATCH 2/6] sched: add function to execute a function synchronously on a physical cpu Juergen Gross
2016-03-11 11:59 ` Juergen Gross [this message]
2016-03-11 11:59 ` [PATCH 4/6] hwmon: use call_sync_on_phys_cpu() for dell-smm i8k Juergen Gross
2016-03-11 11:59 ` [PATCH 5/6] virt, sched: add cpu pinning to call_sync_on_phys_cpu() Juergen Gross
2016-03-11 11:59 ` [PATCH 6/6] xen: add xen_pin_vcpu() to support calling functions on a dedicated pcpu Juergen Gross
[not found] ` <1457697574-6710-3-git-send-email-jgross@suse.com>
2016-03-11 12:19 ` [PATCH 2/6] sched: add function to execute a function synchronously on a physical cpu Peter Zijlstra
[not found] ` <20160311121950.GZ6344@twins.programming.kicks-ass.net>
2016-03-11 12:42 ` Peter Zijlstra
2016-03-11 12:43 ` Juergen Gross
[not found] ` <56E2BD89.4020400@suse.com>
2016-03-11 12:45 ` Peter Zijlstra
[not found] ` <20160311124238.GN6375@twins.programming.kicks-ass.net>
2016-03-11 12:48 ` Juergen Gross
[not found] ` <56E2BE8C.9030309@suse.com>
2016-03-11 12:57 ` Peter Zijlstra
[not found] ` <20160311125706.GC6344@twins.programming.kicks-ass.net>
2016-03-11 13:07 ` Juergen Gross
2016-03-11 12:25 ` [PATCH 0/6] Support calling functions on dedicated " Peter Zijlstra
[not found] ` <20160311122514.GA6344@twins.programming.kicks-ass.net>
2016-03-11 12:28 ` Pali Rohár
2016-03-11 13:15 ` One Thousand Gnomes
2016-03-11 13:19 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1457697574-6710-4-git-send-email-jgross__32514.6098075949$1457697664$gmane$org@suse.com' \
--to=jgross@suse.com \
--cc=Douglas_Warzecha@dell.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=pali.rohar@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).