From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [OSSTEST PATCH 1/2] cri-getprevxenbranch: Only ever return xen-X.Y-testing
Date: Wed, 23 Mar 2016 11:36:06 +0000 [thread overview]
Message-ID: <1458732967-19475-1-git-send-email-ian.jackson@eu.citrix.com> (raw)
Only consider xen-[0-9]* as candidates either for returning, or for
matching the current branch.
The effect is that attempts to ask for the `previous Xen branch' of
anything other than a Xen stable branch give the latest Xen stable
branch, which I think is correct.
This fixes a bug where the `previous branch' of xen-unstable-smoke was
considered to be xen-unstable-coverity (!)
This bug would not have been of any consequence, except that the
coverity tested branch name in xen.bit changed in
c/s d94637b6 "coverity: run tests on smoked rather than master"
and had not been created, so that cr-daily-branch would crash for
most branches because the (largely irrelevant) invocation of
`./ap-fetch-version-old xen-unstable-coverity' would fail.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
cri-getprevxenbranch | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cri-getprevxenbranch b/cri-getprevxenbranch
index a70138e..c4e3ee5 100755
--- a/cri-getprevxenbranch
+++ b/cri-getprevxenbranch
@@ -7,7 +7,7 @@ p=
for b in $(./mg-list-all-branches) ; do # already sorted by version
case "$b" in
- xen*)
+ xen-[0-9]*)
if [ "x$b" = "x$xenbranch" ] ; then
break
else
--
1.7.10.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2016-03-23 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 11:36 Ian Jackson [this message]
2016-03-23 11:36 ` [OSSTEST PATCH 2/2] coverity: Rename branch names to `smoke', not `smoked' Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458732967-19475-1-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).