From: Toshi Kani <toshi.kani@hpe.com>
To: Borislav Petkov <bp@suse.de>
Cc: jgross@suse.com, mcgrof@suse.com, x86@kernel.org,
linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com,
hpa@zytor.com, xen-devel@lists.xenproject.org,
tglx@linutronix.de, mingo@kernel.org, elliott@hpe.com
Subject: Re: [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default PAT MSR
Date: Wed, 23 Mar 2016 09:46:15 -0600 [thread overview]
Message-ID: <1458747975.6393.646.camel__23362.7030429945$1458744914$gmane$org@hpe.com> (raw)
In-Reply-To: <20160323084305.GA8031@pd.tnic>
On Wed, 2016-03-23 at 09:43 +0100, Borislav Petkov wrote:
> On Tue, Mar 22, 2016 at 12:35:19PM -0600, Toshi Kani wrote:
> > Right. Will change to "Add support of non-default PAT MSR setting at
> > handoff".
>
> Please remove this "handoff" notion from the text. Every hw register is
> being handed off to the OS once the kernel takes over so there's no need
> to make it special here.
Will do.
> > I'd like to make it clear that this function does not set PAT MSR,
> > unlike what pat_init() does. When CPU supports PAT, it keeps PAT MSR
> > in whatever the setting at handoff, and initializes PAT table to match
> > with this setting.
> >
> > I am open to a better name, but I am afraid that setup_pat() can be
> > confusing as if it sets PAT MSR.
>
> So call it init_cache_modes() and rename the current
> pat_init_cache_modes() to __init_cache_modes() to denote it is a lower
> level helper of the init_cache_modes() one. The init_cache_modes() one
> deals with the higher level figuring out of whether PAT is enabled and
> if not, preparing the attr bits for emulation. In the end, it calls
> __init_cache_modes(). All nice and easy.
Good idea! Will do.
Thanks,
-Toshi
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-23 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1458175502-31936-1-git-send-email-toshi.kani@hpe.com>
2016-03-17 0:44 ` [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default PAT MSR Toshi Kani
[not found] ` <1458175502-31936-2-git-send-email-toshi.kani@hpe.com>
2016-03-22 16:57 ` Borislav Petkov
[not found] ` <20160322165725.GB5656@pd.tnic>
2016-03-22 18:35 ` Toshi Kani
2016-03-23 8:43 ` Borislav Petkov
2016-03-23 15:46 ` Toshi Kani [this message]
2016-03-22 19:17 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1458747975.6393.646.camel__23362.7030429945$1458744914$gmane$org@hpe.com' \
--to=toshi.kani@hpe.com \
--cc=bp@suse.de \
--cc=elliott@hpe.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).